Skip to content

staging: tidspbridge: remove desgin-by-contract macros

Víctor Manuel Jáquez Leal linux-omap lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4staging: tidspbridge: remove DBC_ENSURE and DBC_REQUIREDdrivers/staging/tidspbridge/core/chnl_sm.c drivers/staging/tidspbridge/core/tiomap3430.c drivers/staging/tidspbridge/gen/uuidutil.c +21 more+3 -9460 replies
2/4staging: tidspbridge: remove DBC_ASSERT macrodrivers/staging/tidspbridge/core/chnl_sm.c drivers/staging/tidspbridge/core/io_sm.c drivers/staging/tidspbridge/core/tiomap3430.c +16 more+2 -1510 replies
3/4staging: tidspbridge: remove dbc.hdrivers/staging/tidspbridge/core/chnl_sm.c drivers/staging/tidspbridge/core/dsp-clock.c drivers/staging/tidspbridge/core/io_sm.c +25 more+0 -1060 replies
4/4staging: tidspbridge: remove CONFIG_TIDSPBRIDGE_DEBUGdrivers/staging/tidspbridge/Kconfig drivers/staging/tidspbridge/core/io_sm.c drivers/staging/tidspbridge/include/dspbridge/io_sm.h+6 -140 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] staging: tidspbridge: remove desgin-by-contract macros

These patches removes all the design-by-contract (DBC) macros in the tidspbridge.

Also it removes the config option CONFIG_TIDSPBRIDGE_DEBUG.

The patches are applied above these submitted patches:
http://thread.gmane.org/gmane.linux.kernel/1246081

The main reasons to remove these DBC macros are

* The kernel in general doesn't follow the DBC approach

* They only provide a needless verbosity, since they are available only when CONFIG_TIDSPBRIDGE_DEBUG is enabled. If they were useful they should be left for the dynamic debugging always. So, if they are not used, is dead code at the end, and should be removed.

* Deleting them means less code to maintain

As the Emperor Joseph II told to Mozart in the motion picture Amadeus:
"It's quality work. And there are simply too many notes, that's all. Just cut a few and it will be perfect."

vmjl

Víctor Manuel Jáquez Leal (4):
staging: tidspbridge: remove DBC_ENSURE and DBC_REQUIRED
staging: tidspbridge: remove DBC_ASSERT macro
staging: tidspbridge: remove dbc.h
staging: tidspbridge: remove CONFIG_TIDSPBRIDGE_DEBUG

 drivers/staging/tidspbridge/Kconfig                |    6 -
 drivers/staging/tidspbridge/core/chnl_sm.c         |   34 +-----
 drivers/staging/tidspbridge/core/dsp-clock.c       |    3 -
 drivers/staging/tidspbridge/core/io_sm.c           |   29 +----
 drivers/staging/tidspbridge/core/msg_sm.c          |    3 -
 drivers/staging/tidspbridge/core/tiomap3430.c      |    9 --
 drivers/staging/tidspbridge/core/tiomap3430_pwr.c  |    1 -
 drivers/staging/tidspbridge/core/tiomap_io.c       |   18 ---
 drivers/staging/tidspbridge/gen/uuidutil.c         |    7 -
 .../staging/tidspbridge/include/dspbridge/dbc.h    |   46 -------
 .../staging/tidspbridge/include/dspbridge/io_sm.h  |    2 -
 drivers/staging/tidspbridge/pmgr/chnl.c            |   19 ---
 drivers/staging/tidspbridge/pmgr/cmm.c             |   68 +----------
 drivers/staging/tidspbridge/pmgr/cod.c             |   74 -----------
 drivers/staging/tidspbridge/pmgr/dbll.c            |  113 +-----------------
 drivers/staging/tidspbridge/pmgr/dev.c             |  132 --------------------
 drivers/staging/tidspbridge/pmgr/dmm.c             |   14 --
 drivers/staging/tidspbridge/pmgr/dspapi.c          |    7 -
 drivers/staging/tidspbridge/pmgr/io.c              |   17 ---
 drivers/staging/tidspbridge/pmgr/msg.c             |   17 ---
 drivers/staging/tidspbridge/rmgr/dbdcd.c           |   88 -------------
 drivers/staging/tidspbridge/rmgr/disp.c            |   44 -------
 drivers/staging/tidspbridge/rmgr/drv.c             |   48 -------
 drivers/staging/tidspbridge/rmgr/drv_interface.c   |    6 -
 drivers/staging/tidspbridge/rmgr/dspdrv.c          |    5 -
 drivers/staging/tidspbridge/rmgr/mgr.c             |   36 ------
 drivers/staging/tidspbridge/rmgr/nldr.c            |   71 -----------
 drivers/staging/tidspbridge/rmgr/node.c            |   98 ---------------
 drivers/staging/tidspbridge/rmgr/proc.c            |   91 --------------
 drivers/staging/tidspbridge/rmgr/rmm.c             |   36 ------
 drivers/staging/tidspbridge/rmgr/strm.c            |   86 +-------------
 31 files changed, 11 insertions(+), 1217 deletions(-)
 delete mode 100644 drivers/staging/tidspbridge/include/dspbridge/dbc.h
Signature · 1 line
1.7.8.3