Another bundle fix: reading freed memory
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | t5510: refactor bundle->pack conversiont/ | +10 | 0 replies | |
| 2/4 | t5510: fix indent with spacest/ | +8 | 0 replies | |
| 3/4 | t5510: ensure we stay in the toplevel test dirt/ | +1 | 4 replies | |
| 4/4 | bundle: keep around names passed to add_pending_object()bundle.c t/ | +17 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] Another bundle fix: reading freed memory
This is about the fourth patch, the other three are just cleanups. Valgrind caught me reading free()d memory after the recent change to a strbuf in create_bundle. Luckily it's the only report I got.
I made a token effort to verify that nobody else is playing mind games with the .name fields in struct object_array, but I'm rather tired so it would be nice if someone could double-check. In any case bundle is the only user of object_array_remove_duplicates.
Thomas Rast (4):
t5510: refactor bundle->pack conversion
t5510: fix indent with spaces
t5510: ensure we stay in the toplevel test dir
bundle: keep around names passed to add_pending_object()
bundle.c | 2 +- t/t5510-fetch.sh | 57 +++++++++++++++++++++++++++++++++--------------------- 2 files changed, 36 insertions(+), 23 deletions(-)
Signature · 1 line
1.7.9.2.467.g7fee4