Skip to content

Fix documented fixme's throughout

Jared Hance git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest3 patches 3 repliesIn review

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Fix memory leak in apply_patch in apply.c.builtin/apply.c+28 -33 replies
2/3Add threaded versions of functions in symlinks.c.cache.h symlinks.c+28 -21 reply
3/3Use startup_info->prefix rather than prefix.cache.h git.c trace.c+7 -71 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] Fix documented fixme's throughout

A few patches that (hopefully) don't change the behavior of git except to rectify a memory error. Also, this should ever so slightly help with the parallelism of git (a GSoC proposal). All of these were found with commented FIXME and git grep.

Jared Hance (3):
Fix memory leak in apply_patch in apply.c. Add threaded versions of functions in symlinks.c. Use startup_info->prefix rather than prefix.

 builtin/apply.c |   31 ++++++++++++++++++++++++++++---
 cache.h         |    4 +++-
 git.c           |    2 +-
 symlinks.c      |   28 ++++++++++++++++++++++++++--
 trace.c         |   10 +++++-----
 5 files changed, 63 insertions(+), 12 deletions(-)
Signature · 6 lines
Minor style changes and move the most controversial commit to the end of the
patch series.

Sorry, accidently sent out an old saved version of this just a bit before.

1.7.3.4