Hob tweaks
Status from this message: I've merged the first four, the last two seemed to be being discussed...
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | ui/crumbs/hig: use close rather than OK for dismis buttonlib/ | +1 | 1 reply | |
| 2/6 | ui/crumbs: remove unused return value from append_toolbar_buttonlib/ lib/ lib/ | +5 | 1 reply | |
| 3/6 | ui/crumbs/hobpage: no need to force a Toolbar button typelib/ | +1 | 1 reply | |
| 4/6 | ui/crumbs/persistenttooltip: try to reflect WM close button positionlib/ | +23 | 1 reply | |
| 5/6 | ui/crumbs/builder: remove OK/Cancel buttons on Layer dialog. Use Close.lib/ | +1 | 2 replies | |
| 6/6 | ui/crumbs/hig: make the layer selection dialogue more closely match designlib/ | +74 | 2 replies |
Reviews trailers per patch
4 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Dongxiao Xu |
|---|---|
| 1/6 | A-b |
| 2/6 | A-b |
| 3/6 | A-b |
| 4/6 | A-b |
| 5/6 | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/6] Hob tweaks
Here's a series of patches to polish the Hob GUI: some minor tweaks to remove redundant calls and API, a couple of HIG related tweaks to buttons, a change to the persistenttooltip to try and match the close position of the window manager (i.e. running under Unity on Ubuntu the close button on the persistent tooltip will appear on the left) and finally a change to the layer dialogue implementation so that it more closely matches the interaction design (this is still pending some designer feedback on visuals and whether to remove some labels but they can easily be implemented as iterative patches on top of these).
Cheers,
Joshua
The following changes since commit 5a1e62a8cdd4f0253b0dc59046b3b4c3186af461:
bitbake/fetch2: Fix typo which broke use of tarballs (2012-03-16 23:44:08 +0000)
are available in the git repository at:
git://github.com/incandescant/bitbake josh/hob
https://github.com/incandescant/bitbake/tree/josh/hob
git://git.yoctoproject.org/poky-contrib josh/hob
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=josh/hob
Joshua Lock (6):
ui/crumbs/hig: use close rather than OK for dismis button ui/crumbs: remove unused return value from append_toolbar_button ui/crumbs/hobpage: no need to force a Toolbar button type ui/crumbs/persistenttooltip: try to reflect WM close button position ui/crumbs/builder: remove OK/Cancel buttons on Layer dialog. Use
Close.
ui/crumbs/hig: make the layer selection dialogue more closely match
design
lib/bb/ui/crumbs/builder.py | 3 +- lib/bb/ui/crumbs/hig.py | 98 +++++++++++++++++++++------- lib/bb/ui/crumbs/hobpages.py | 6 +- lib/bb/ui/crumbs/imageconfigurationpage.py | 6 +- lib/bb/ui/crumbs/imagedetailspage.py | 2 +- lib/bb/ui/crumbs/persistenttooltip.py | 24 +++++++- 6 files changed, 105 insertions(+), 34 deletions(-)
Signature · 1 line
1.7.7.6