Skip to content

Hob changes to match visual design

Joshua Lock bitbake-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9lib/bb/ui/icons: add new icons for use in Hob, autocrop some existing oneslib/bb/ui/icons/indicators/add-hover.png lib/bb/ui/icons/indicators/remove-hover.png lib/bb/ui/icons/layers/layers_hover.png +2 more+0 -00 replies
2/9lib/bb/ui/crumbs: replace HobXpmLabelButtonBox with HobImageButtonlib/bb/ui/crumbs/hobwidget.py lib/bb/ui/crumbs/imageconfigurationpage.py+85 -780 replies
3/9lib/bb/ui/crumbs/builder: only show a close button on the Layer Selectorlib/bb/ui/crumbs/builder.py+1 -20 replies
4/9lib/bb/ui/crumbs/hig: tweak 'Add Layer' button per visual designlib/bb/ui/crumbs/hig.py+16 -110 replies
5/9lib/bb/ui/crumbs: add colour for HobAltButton per visual designlib/bb/ui/crumbs/hobcolor.py lib/bb/ui/crumbs/hobwidget.py+4 -20 replies
6/9lib/bb/ui/crumbs: fix 'Back to image configuration' alt button textlib/bb/ui/crumbs/packageselectionpage.py lib/bb/ui/crumbs/recipeselectionpage.py+2 -20 replies
7/9lib/bb/ui/crumbs/hobwidget: add HobButton widget for the primary actionlib/bb/ui/crumbs/hobwidget.py+20 -00 replies
8/9lib/bb/ui/crumbs: make use of HobButton for existing primary action buttonslib/bb/ui/crumbs/imageconfigurationpage.py lib/bb/ui/crumbs/imagedetailspage.py lib/bb/ui/crumbs/packageselectionpage.py +1 more+7 -380 replies
9/9lib/bb/ui/crumbs/builder: change dialogue title to Layerslib/bb/ui/crumbs/builder.py+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] Hob changes to match visual design

Here's another set of patches to move Hob closer to the proposed design.

* Replace HobXpmLabelButtonBox with a new HobImageButton, this is a gtk.Button subclass which is modelled after the buttons in gnome-disk-utility, where Belen informs me the buttons on the main page for Layers, Recipes and Packages are modelled after.
Since the first submission of this patch I've also ensured the buttons use an alternative icon for the hover state per Shane's suggestion.

* Various tweaks to the LayerSelectionDialog per feedback from design:
- title is Layers
- add hover state icon to add button
- follow Gnome HIG and only use a close button

* Per feedback on my last pull request and the design document changes to the HobAltButton
- bold text which uses a pale blue colour per visual design
- modified 'Back to image configuration' buttons to have << prefix

* Unify implementation of the primary action button as a shared widget HobButton and make use of it where we currently set up an orange button (this class should be used for all primary buttons in a future patch).

Cheers,
Joshua

The following changes since commit 96e235a151fa04f5a15cd8b46f50a5852e2ba739:

Hob: Revert interfaces of callbacks for layer_button, view_recipes_button, and view_packages_button. (2012-03-22 14:36:04 +0000)

are available in the git repository at:
git://github.com/incandescant/bitbake josh/hob
https://github.com/incandescant/bitbake/tree/josh/hob
git://git.yoctoproject.org/poky-contrib josh/hob
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=josh/hob

Joshua Lock (9):
lib/bb/ui/icons: add new icons for use in Hob, autocrop some existing
ones
lib/bb/ui/crumbs: replace HobXpmLabelButtonBox with HobImageButton lib/bb/ui/crumbs/builder: only show a close button on the Layer
Selector
lib/bb/ui/crumbs/hig: tweak 'Add Layer' button per visual design lib/bb/ui/crumbs: add colour for HobAltButton per visual design lib/bb/ui/crumbs: fix 'Back to image configuration' alt button text lib/bb/ui/crumbs/hobwidget: add HobButton widget for the primary
action
lib/bb/ui/crumbs: make use of HobButton for existing primary action
buttons
lib/bb/ui/crumbs/builder: change dialogue title to Layers

 lib/bb/ui/crumbs/builder.py                 |    5 +-
 lib/bb/ui/crumbs/hig.py                     |   27 +++--
 lib/bb/ui/crumbs/hobcolor.py                |    1 +
 lib/bb/ui/crumbs/hobwidget.py               |  148 ++++++++++++++++-----------
 lib/bb/ui/crumbs/imageconfigurationpage.py  |   52 ++++------
 lib/bb/ui/crumbs/imagedetailspage.py        |   11 +--
 lib/bb/ui/crumbs/packageselectionpage.py    |   13 +--
 lib/bb/ui/crumbs/recipeselectionpage.py     |   13 +--
 lib/bb/ui/icons/indicators/add-hover.png    |  Bin 0 -> 1212 bytes
 lib/bb/ui/icons/indicators/remove-hover.png |  Bin 0 -> 2809 bytes
 lib/bb/ui/icons/layers/layers_hover.png     |  Bin 5390 -> 5257 bytes
 lib/bb/ui/icons/packages/packages_hover.png |  Bin 7308 -> 7121 bytes
 lib/bb/ui/icons/recipe/recipe_hover.png     |  Bin 5003 -> 4866 bytes
 13 files changed, 136 insertions(+), 134 deletions(-)
 create mode 100644 lib/bb/ui/icons/indicators/add-hover.png
 create mode 100644 lib/bb/ui/icons/indicators/remove-hover.png
Signature · 1 line
1.7.7.6