Skip to content

RFC Replace HobNotebook with gtk.Notebook

Joshua Lock bitbake-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3lib/bb/ui/crumbs/: replace custom HobNotebooklib/bb/ui/crumbs/builddetailspage.py lib/bb/ui/crumbs/hobwidget.py lib/bb/ui/crumbs/packageselectionpage.py +1 more+82 -3980 replies
2/3lib/bb/ui/crumbs/hobwidget: use light text in HobIndicatorlib/bb/ui/crumbs/hobwidget.py+1 -10 replies
3/3lib/bb/ui/crumbs/imageconfiguration: fix combo boxes drop-down widthlib/bb/ui/crumbs/imageconfigurationpage.py+0 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/3] Replace HobNotebook with gtk.Notebook

The important patch in this RFC is the first which replaces the fully custom HobNotebook with a simpler gtk.Notebook subclass.

It's an RFC as there's currently what looks like a rendering glitch in how the tabs are displayed. See the white boxes in the tabs of this screenshot:
https://bugzilla.yoctoproject.org/attachment.cgi?id=465

I'm researching how to remove this artifact but wanted to gather feedback on the patch as it stands as we are close to the checkin deadline.

Thanks,
Joshua

The following changes since commit 3c2808b67384e92601cbd66877c36ca40df7c7ba:

Hob: fix the missing functions (2012-04-12 15:56:42 +0100)

are available in the git repository at:
git://github.com/incandescant/bitbake josh/hob
https://github.com/incandescant/bitbake/tree/josh/hob

Joshua Lock (3):
lib/bb/ui/crumbs/: replace custom HobNotebook lib/bb/ui/crumbs/hobwidget: use light text in HobIndicator lib/bb/ui/crumbs/imageconfiguration: fix combo boxes drop-down width

 lib/bb/ui/crumbs/builddetailspage.py       |    4 +-
 lib/bb/ui/crumbs/hobwidget.py              |  468 +++++-----------------------
 lib/bb/ui/crumbs/imageconfigurationpage.py |    2 -
 lib/bb/ui/crumbs/packageselectionpage.py   |    3 +-
 lib/bb/ui/crumbs/recipeselectionpage.py    |    5 +-
 5 files changed, 82 insertions(+), 400 deletions(-)
Signature · 1 line
1.7.7.6