clk: Add non CONFIG_HAVE_CLK routines
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest posting 2/212 patches 3 repliesIn review
- v3 posting 1/212 patches 17 repliesSuperseded
- v29 patches 4 repliesSuperseded
Changes in v3 from the cover letter
- Dummy routines now return NULL or 0.
- All user drivers must fail if clk_get returned error other than NULL.
- All user drivers don't need to validate their clk pointer before every call to clk_*() routines.
- Patches dropped earlier are again taken back, as they were following similar approach to what is implemented now.
Patches in v3 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | clk: Add non CONFIG_HAVE_CLK routinesinclude/ | +109 | 0 replies | |
| 2/12 | clk: Remove redundant depends on from drivers/Kconfigdrivers/ | +0 | 0 replies | |
| 3/12 | i2c/i2c-pxa: Remove conditional compilation of clk codedrivers/ | +0 | 0 replies | |
| 4/12 | usb/marvell: Remove conditional compilation of clk codeinclude/ | +0 | 0 replies | |
| 5/12 | usb/musb: Remove conditional compilation of clk codedrivers/ | +0 | 0 replies | |
| 6/12 | ata/pata_arasan: Remove conditional compilation of clk codedrivers/ | +1 | 0 replies | |
| 7/12 | ata/sata_mv: Remove conditional compilation of clk codedrivers/ | +0 | 1 reply | |
| 8/12 | net/c_can: Remove conditional compilation of clk codedrivers/ | +0 | 1 reply | |
| 9/12 | net/stmmac: Remove conditional compilation of clk codedrivers/ drivers/ | +17 | 1 reply | |
| 10/12 | gadget/m66592: Remove conditional compilation of clk codedrivers/ drivers/ | +1 | 0 replies | |
| 11/12 | gadget/r8a66597: Remove conditional compilation of clk codedrivers/ drivers/ | +3 | 0 replies | |
| 12/12 | usb/host/r8a66597: Remove conditional compilation of clk codedrivers/ drivers/ | +0 | 0 replies |
Reviews trailers per patch
4 of 12 patches have a Reviewed-by or Acked-by.
| Patch | Wolfram Sang | Andrew Lunn | David S. Miller |
|---|---|---|---|
| 1/12 | |||
| 2/12 | |||
| 3/12 | A-b | ||
| 4/12 | |||
| 5/12 | |||
| 6/12 | |||
| 7/12 | R-b R-b | ||
| 8/12 | A-b | ||
| 9/12 | A-b | ||
| 10/12 | |||
| 11/12 | |||
| 12/12 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH V3 Resend 00/12] clk: Add non CONFIG_HAVE_CLK routines
Hi,
I am resending this patchset as Andrew didn't get few patches of this set. Also i have updated patches with Acked-by or Reviewed by of people who replied with these strings.
Last time there were few discussion over this patchset which can be found at
http://lkml.org/lkml/2012/4/24/154
Many drivers are shared between architectures that may or may not have HAVE_CLK selected for them. To remove compilation errors for them we enclose clk_*() calls in these drivers within #ifdef CONFIG_HAVE_CLK, #endif.
This patchset removes the need of these CONFIG_HAVE_CLK statements, by introducing dummy routines when HAVE_CLK is not selected by platforms. So, definition of these routines will always be available. These calls will return error for platforms that don't select HAVE_CLK.
V2->V3:
- Dummy routines now return NULL or 0.
- All user drivers must fail if clk_get returned error other than NULL.
- All user drivers don't need to validate their clk pointer before every call to clk_*() routines.
- Patches dropped earlier are again taken back, as they were following similar approach to what is implemented now.
Viresh Kumar (12):
clk: Add non CONFIG_HAVE_CLK routines
clk: Remove redundant depends on from drivers/Kconfig i2c/i2c-pxa: Remove conditional compilation of clk code usb/marvell: Remove conditional compilation of clk code usb/musb: Remove conditional compilation of clk code ata/pata_arasan: Remove conditional compilation of clk code ata/sata_mv: Remove conditional compilation of clk code net/c_can: Remove conditional compilation of clk code net/stmmac: Remove conditional compilation of clk code gadget/m66592: Remove conditional compilation of clk code gadget/r8a66597: Remove conditional compilation of clk code usb/host/r8a66597: Remove conditional compilation of clk code
drivers/ata/pata_arasan_cf.c | 14 +-- drivers/ata/sata_mv.c | 10 -- drivers/clk/Kconfig | 2 - drivers/i2c/busses/i2c-pxa.c | 7 - drivers/net/can/c_can/c_can_platform.c | 8 - drivers/net/ethernet/stmicro/stmmac/stmmac.h | 41 ----- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 33 ++-- drivers/usb/gadget/m66592-udc.c | 9 +- drivers/usb/gadget/m66592-udc.h | 5 - drivers/usb/gadget/r8a66597-udc.c | 11 +- drivers/usb/gadget/r8a66597-udc.h | 5 - drivers/usb/host/r8a66597-hcd.c | 12 -- drivers/usb/host/r8a66597.h | 5 - drivers/usb/musb/musb_core.h | 8 - include/linux/clk.h | 168 +++++++++++++------- include/linux/platform_data/mv_usb.h | 9 - 16 files changed, 131 insertions(+), 216 deletions(-)
Signature · 1 line
1.7.9