Skip to content

correct behavior when modify primary via sysfs

Weiping Pan netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3bonding:record primary when modify it via sysfsdrivers/net/bonding/bond_sysfs.c+6 -25 replies
2/3bonding:check mode when modify primary_reselectdrivers/net/bonding/bond_sysfs.c+7 -04 replies
3/3bonding:force to use primary slavedrivers/net/bonding/bond_sysfs.c+1 -05 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchNicolas de Pesloüan
1/3A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/3] correct behavior when modify primary via sysfs

There is a problem that when we set primary slave with module parameters, bond will always use this primary slave as active slave.

But when we modify primary slave via sysfs, it will call bond_should_change_active() and take into account primary_reselect.

And I think we should use the new primary slave as the new active slave regardless of the value of primary_reselect.
Thus the behavior is the same with module parameters and meets the administrator's expectation.

Weiping Pan (3):
bonding:record primary when modify it via sysfs
bonding:check mode when modify primary_reselect
bonding:force to use primary slave

 drivers/net/bonding/bond_sysfs.c |   16 ++++++++++++++--
 1 files changed, 14 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.4