Skip to content

fdc: fix/rewrite seek, media_changed and interrupt handling

Pavel Hrdina qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 2 repliesIn review
  2. v54 patches 2 repliesSuperseded
  3. v44 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v34 patches3 repliesSuperseded

Changes in v6 from the cover letter

- update fdc_test test_media_change
- add fdc-test test_sense_interrupt

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6fdc: fix implied seek while there is no media in drivehw/fdc.c+4 -00 replies
2/6fdc-test: introduced qtest read_without_mediatests/fdc-test.c+66 -00 replies
3/6fdc: rewrite seek and DSKCHG bit handlinghw/fdc.c+41 -380 replies
4/6fdc: fix interrupt handlinghw/fdc.c+21 -130 replies
5/6fdc_test: update media_change testtests/fdc-test.c+21 -82 replies
6/6fdc_test: introduce test_sense_interrupttests/fdc-test.c+24 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [Qemu-devel] [PATCH v6 0/6] fdc: fix/rewrite seek, media_changed and interrupt handling

The fd_seek will return 'track is invalid' if there is no media in drive.

Implied seek should have the same behavior as normal seek. We will use the fd_seek function instead of a direct modification of head, track and sector values. The result value is used only while read/write commands were issued.

Fix sense interrupt status command.

v6:
- update fdc_test test_media_change
- add fdc-test test_sense_interrupt

v5:
- correction of misspelled words

v4:
- fix coding style
- better bit clearing in 'fdctrl_handle_sense_interrupt_status'

v3:
- add fdc-test test_read_without_media
- rewrite seek and media_changed handling
- fix interrupt status handling

v2:
- better way to detect media missing

Pavel Hrdina (6):
fdc: fix implied seek while there is no media in drive
fdc-test: introduced qtest read_without_media
fdc: rewrite seek and DSKCHG bit handling
fdc: fix interrupt handling
fdc_test: update media_change test
fdc_test: introduce test_sense_interrupt

 hw/fdc.c         |  117 ++++++++++++++++++++++++++++++-----------------------
 tests/fdc-test.c |  118 ++++++++++++++++++++++++++++++++++++++++++++++++++----
 2 files changed, 176 insertions(+), 59 deletions(-)
Signature · 1 line
1.7.7.6