Skip to content

dcbnl: Major simplifications

Thomas Graf netdev 1 version Applied

Status from this message: Applied, but could you send a follow-on patch to use BUG_ON() instead

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 6 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/8dcbnl: Prepare framework to shorten handling functionsnet/dcb/dcbnl.c+71 -00 replies
2/8dcbnl: Shorten all command handling functionsnet/dcb/dcbnl.c+172 -5501 reply
3/8dcbnl: Remove now unused dcbnl_reply()net/dcb/dcbnl.c+0 -370 replies
4/8dcbnl: Use dcbnl_newmsg() where possiblenet/dcb/dcbnl.c+2 -140 replies
5/8dcbnl: Return consistent error codesnet/dcb/dcbnl.c+138 -1350 replies
6/8dcbnl: Move dcb app lookup code into dcb_app_lookup()net/dcb/dcbnl.c+35 -460 replies
7/8dcbnl: Move dcb app allocation into dcb_app_add()net/dcb/dcbnl.c+22 -250 replies
8/8dcbnl: Use type safe nlmsg_data()net/dcb/dcbnl.c+1 -10 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by.

Patch[email protected]
SeriesT-b
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] dcbnl: Major simplifications

The dcbnl code is overly complicated when constructing the reply message. This series of patches simplifies the process and introduces consistent error codes allowing user space to figure out what went wrong.

Patches have been tested with ixgbe in a FCoE setup.

Thomas Graf (8):
dcbnl: Prepare framework to shorten handling functions
dcbnl: Shorten all command handling functions
dcbnl: Remove now unused dcbnl_reply()
dcbnl: Use dcbnl_newmsg() where possible
dcbnl: Return consistent error codes
dcbnl: Move dcb app lookup code into dcb_app_lookup()
dcbnl: Move dcb app allocation into dcb_app_add()
dcbnl: Use type safe nlmsg_data()

 net/dcb/dcbnl.c | 1169 +++++++++++++++++++------------------------------------
 1 files changed, 401 insertions(+), 768 deletions(-)
Signature · 1 line
1.7.7.6