Skip to content

Several cleanings and style fixes

Miguel Gómez lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest19 patches 3 repliesIn review
  2. v119 patches 13 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19Staging: xgifb: Comment cleaning.drivers/staging/xgifb/XGI_main.h drivers/staging/xgifb/XGI_main_26.c drivers/staging/xgifb/XGIfb.h +5 more+61 -3060 replies
2/19Staging: xgifb: Remove unneeded XGI_LCD_TYPE enumeration.drivers/staging/xgifb/vgatypes.h+0 -340 replies
3/19Staging: xgifb: Remove LCDA detection in xgifb_probe().drivers/staging/xgifb/XGI_main_26.c+0 -303 replies
4/19Staging: xgifb: Remove unused struct _chswtable.drivers/staging/xgifb/XGI_main.h+0 -100 replies
5/19Staging: xgifb: Improve debug strings.drivers/staging/xgifb/XGI_main_26.c drivers/staging/xgifb/vb_init.c+19 -190 replies
6/19Staging: xgifb: Remove useless switch in XGIfb_detect_VB().drivers/staging/xgifb/XGI_main_26.c+0 -100 replies
7/19Staging: xgifb: Simplify XGIfb_GetXG21DefaultLVDSModeIdx().drivers/staging/xgifb/XGI_main_26.c+9 -180 replies
8/19Staging: xgifb: Remove unneeded var and condition in XGIfb_search_vesamode().drivers/staging/xgifb/XGI_main_26.c+3 -50 replies
9/19Staging: xgifb: Remove useless always true condition.drivers/staging/xgifb/vb_init.c+0 -40 replies
10/19Staging: xgifb: Rework conditions in XGI_SetATTRegs().drivers/staging/xgifb/vb_setmode.c+8 -110 replies
11/19Staging: xgifb: Refactor XGI_AjustCRT2Rate().drivers/staging/xgifb/vb_setmode.c+25 -480 replies
12/19Staging: xgifb: Refactor XGI_GetVBType().drivers/staging/xgifb/vb_setmode.c+36 -330 replies
13/19Staging: xgifb: Rework conditions in XGI_GetVBInfo().drivers/staging/xgifb/vb_setmode.c+142 -1450 replies
14/19Staging: xgifb: Refactor XGI_GetCRT2ResInfo().drivers/staging/xgifb/vb_setmode.c+31 -300 replies
15/19Staging: xgifb: Rework conditions in XGI_SetLockRegs().drivers/staging/xgifb/vb_setmode.c+10 -180 replies
16/19Staging: xgifb: Rework conditions in XGI_EnableBridge().drivers/staging/xgifb/vb_setmode.c+18 -260 replies
17/19Staging: xgifb: Rework some conditions in XGI_SetCRT2ModeRegs().drivers/staging/xgifb/vb_setmode.c+36 -470 replies
18/19Staging: xgifb: Fix coding style.drivers/staging/xgifb/XGI_main_26.c drivers/staging/xgifb/vb_init.c drivers/staging/xgifb/vb_setmode.c +1 more+58 -370 replies
19/19Staging: xgifb: Remove useless condition.drivers/staging/xgifb/XGI_main_26.c+0 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH 00/19 v2] Several cleanings and style fixes

Hi!

Second version of the patches round containing suggestions made to the first version:

* patch 0001:
** keep some useful comments.
** format a couple of multiline comments
** don't remove empty lines in vb_util.h and vb_init.h

* patch 0005:
** remove exclamation marks from a string

* patch 0015
** simplify a bit more by joining another couple of conditions

* patch 0017
** replace do-while with gotos

* patch 0018
** move some comments to previous line instead of modifying them

Also, I'm sending all of the patches again because they were encoded in base64 instead of 8bit.

Regards!

Miguel Gómez (19):
Staging: xgifb: Comment cleaning.
Staging: xgifb: Remove unneeded XGI_LCD_TYPE enumeration.
Staging: xgifb: Remove LCDA detection in xgifb_probe().
Staging: xgifb: Remove unused struct _chswtable.
Staging: xgifb: Improve debug strings.
Staging: xgifb: Remove useless switch in XGIfb_detect_VB().
Staging: xgifb: Simplify XGIfb_GetXG21DefaultLVDSModeIdx().
Staging: xgifb: Remove unneeded var and condition in
XGIfb_search_vesamode().
Staging: xgifb: Remove useless always true condition.
Staging: xgifb: Rework conditions in XGI_SetATTRegs().
Staging: xgifb: Refactor XGI_AjustCRT2Rate().
Staging: xgifb: Refactor XGI_GetVBType().
Staging: xgifb: Rework conditions in XGI_GetVBInfo().
Staging: xgifb: Refactor XGI_GetCRT2ResInfo().
Staging: xgifb: Rework conditions in XGI_SetLockRegs().
Staging: xgifb: Rework conditions in XGI_EnableBridge().
Staging: xgifb: Rework some conditions in XGI_SetCRT2ModeRegs().
Staging: xgifb: Fix coding style.
Staging: xgifb: Remove useless condition.

 drivers/staging/xgifb/XGI_main.h    |   14 -
 drivers/staging/xgifb/XGI_main_26.c |  247 +++---------
 drivers/staging/xgifb/XGIfb.h       |    8 +-
 drivers/staging/xgifb/vb_def.h      |    3 -
 drivers/staging/xgifb/vb_init.c     |  166 +-------
 drivers/staging/xgifb/vb_setmode.c  |  747 ++++++++++++++++-------------------
 drivers/staging/xgifb/vb_struct.h   |    3 -
 drivers/staging/xgifb/vb_table.h    |   65 ++-
 drivers/staging/xgifb/vgatypes.h    |   34 --
 9 files changed, 455 insertions(+), 832 deletions(-)
Signature · 1 line
1.7.9.5

Read the cover letter in its thread