Skip to content

build system: support automatic reconfiguration for autotools user

Stefano Lattarini git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest7 patches 3 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7autoconf: GIT_CONF_APPEND_LINE: change signatureconfigure.ac+14 -140 replies
2/7autoconf: GIT_CONF_APPEND_LINE -> GIT_CONF_SUBSTconfigure.ac+12 -120 replies
3/7autoconf: remove some redundant shell indirectionsconfigure.ac+5 -70 replies
4/7autoconf: remove few redundant semicolonsconfigure.ac+2 -20 replies
5/7autoconf: use AC_CONFIG_COMMANDS instead of ad-hoc 'config.mak.append'configure.ac+17 -110 replies
6/7build: "make clean" should not remove configure-generated filesMakefile+3 -22 replies
7/7build: reconfigure automatically if configure.ac changesMakefile configure.ac+14 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/7] build system: support automatic reconfiguration for autotools user
Quoted 3 lines

Except for miniscule nits in the the bottom two, I didn't find anything objectionable---nicely done.

Thanks.

Here is the re-roll, which should address all the reported nits.

Stefano Lattarini (7):
autoconf: GIT_CONF_APPEND_LINE: change signature
autoconf: GIT_CONF_APPEND_LINE -> GIT_CONF_SUBST
autoconf: remove some redundant shell indirections
autoconf: remove few redundant semicolons
autoconf: use AC_CONFIG_COMMANDS instead of ad-hoc 'config.mak.append'
build: "make clean" should not remove configure-generated files
build: reconfigure automatically if configure.ac changes

 Makefile     | 17 +++++++++++++++--
 configure.ac | 56 +++++++++++++++++++++++++++++++-------------------------
 2 files changed, 46 insertions(+), 27 deletions(-)
Signature · 1 line
1.7.10.2.1067.g553d16e

Read the cover letter in its thread