Skip to content

qapi: Convert savevm, loadvm, delvm and info snapshots

Pavel Hrdina qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest17 patches 15 repliesIn review
  2. v118 patches 22 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17error: introduce handle_errorerror.c error.h+14 -02 replies
2/17block: add error parameter to bdrv_snapshot_create() and related functionsblock.c block.h block/qcow2-snapshot.c +6 more+60 -322 replies
3/17block: add error parameter to bdrv_snapshot_goto() and related functionsblock.c block.h block/qcow2-snapshot.c +6 more+49 -311 reply
4/17block: add error parameter to bdrv_snapshot_delete() and related functionsblock.c block.h block/qcow2-snapshot.c +6 more+48 -210 replies
5/17block: add error parameter to bdrv_snapshot_list() and related functionsblock.c block.h block/qcow2-snapshot.c +6 more+47 -190 replies
6/17block: add error parameter to bdrv_snapshot_find()savevm.c+18 -100 replies
7/17block: add error parameter to del_existing_snapshots()savevm.c+4 -81 reply
8/17savevm: add error parameter to qemu_savevm_state_begin()migration.c savevm.c sysemu.h+8 -41 reply
9/17savevm: add error parameter to qemu_savevm_state_iterate()migration.c savevm.c sysemu.h+12 -40 replies
10/17savevm: add error parameter to qemu_savevm_state_complete()migration.c savevm.c sysemu.h+13 -50 replies
11/17savevm: add error parameter to qemu_savevm_state()savevm.c+11 -80 replies
12/17savevm: add error parameter to qemu_loadvm_state()migration.c savevm.c sysemu.h+29 -211 reply
13/17qapi: Convert savevmhmp-commands.hx hmp.c hmp.h +4 more+70 -192 replies
14/17qapi: Convert loadvmhmp-commands.hx hmp.c hmp.h +6 more+90 -481 reply
15/17qapi: Convert delvmhmp-commands.hx hmp.c hmp.h +4 more+53 -161 reply
16/17qapi: Convert info snapshotshmp.c hmp.h monitor.c +4 more+107 -301 reply
17/17vm-snapshot-save: add force parameterhmp-commands.hx hmp.c qapi-schema.json +2 more+60 -390 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 00/17] qapi: Convert savevm, loadvm, delvm and info snapshots

This patch series convert these commands into qapi and introduce QMP commands vm-snapshot-save, vm-snapshot-load, vm-snapshot-delete and query-vm-snapshots. It also rewrite error report for functions used by these commands.

Last patch introduce new functionality of savevm and vm-snapshot-save that you cannot override existing snapshot without using 'force' parameter and for QMP you have to always provide name parameter.

We should also merge functionality of migrations and vm-snapshots and make some clean-ups of this code. I could do it as another patch. With this rewrite we could make vm-snapshots asynchronous.

Pavel Hrdina (17):
error: introduce handle_error
block: add error parameter to bdrv_snapshot_create() and related
functions
block: add error parameter to bdrv_snapshot_goto() and related
functions
block: add error parameter to bdrv_snapshot_delete() and related
functions
block: add error parameter to bdrv_snapshot_list() and related
functions
block: add error parameter to bdrv_snapshot_find()
block: add error parameter to del_existing_snapshots()
savevm: add error parameter to qemu_savevm_state_begin()
savevm: add error parameter to qemu_savevm_state_iterate()
savevm: add error parameter to qemu_savevm_state_complete()
savevm: add error parameter to qemu_savevm_state()
savevm: add error parameter to qemu_loadvm_state()
qapi: Convert savevm
qapi: Convert loadvm
qapi: Convert delvm
qapi: Convert info snapshots
vm-snapshot-save: add force parameter

 block.c                | 106 ++++++++++++------
 block.h                |  13 ++-
 block/qcow2-snapshot.c |  41 ++++++-
 block/qcow2.h          |  16 ++-
 block/rbd.c            |  33 ++++--
 block/sheepdog.c       |  45 +++++---
 block_int.h            |  13 ++-
 error.c                |   8 ++
 error.h                |   6 +
 hmp-commands.hx        |  24 ++--
 hmp.c                  |  84 ++++++++++++++
 hmp.h                  |   4 +
 migration.c            |  14 +--
 monitor.c              |  14 +--
 qapi-schema.json       |  64 +++++++++++
 qemu-img.c             |  28 ++---
 qmp-commands.hx        | 115 +++++++++++++++++++
 savevm.c               | 297 +++++++++++++++++++++++++------------------------
 sysemu.h               |  17 ++-
 vl.c                   |   6 +-
 20 files changed, 663 insertions(+), 285 deletions(-)
Signature · 1 line
1.8.0.2

Read the cover letter in its thread