Skip to content

dev_<level> and dynamic_debug cleanups

Joe Perches lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5dev_dbg/dynamic_debug: Update to use printk_emit, optimize stackdrivers/base/core.c include/linux/device.h lib/dynamic_debug.c+67 -440 replies
1/5dev_dbg/dynamic_debug: Update to use printk_emit, optimize stackdrivers/base/core.c include/linux/device.h lib/dynamic_debug.c+67 -440 replies
2/5netdev_printk/dynamic_netdev_dbg: Directly call printk_emitinclude/linux/netdevice.h lib/dynamic_debug.c net/core/dev.c+40 -130 replies
2/5netdev_printk/dynamic_netdev_dbg: Directly call printk_emitinclude/linux/netdevice.h lib/dynamic_debug.c net/core/dev.c+40 -130 replies
3/5netdev_printk/netif_printk: Remove a superfluous logging colonlib/dynamic_debug.c net/core/dev.c+2 -20 replies
3/5netdev_printk/netif_printk: Remove a superfluous logging colonlib/dynamic_debug.c net/core/dev.c+2 -20 replies
4/5dev: Add dev_vprintk_emit and dev_printk_emitdrivers/base/core.c include/linux/device.h+38 -02 replies
4/5dev: Add dev_vprintk_emit and dev_printk_emitdrivers/base/core.c include/linux/device.h+38 -00 replies
5/5device and dynamic_debug: Use dev_vprintk_emit and dev_printk_emitdrivers/base/core.c include/linux/device.h lib/dynamic_debug.c +1 more+22 -410 replies
5/5device and dynamic_debug: Use dev_vprintk_emit and dev_printk_emitdrivers/base/core.c include/linux/device.h lib/dynamic_debug.c +1 more+22 -410 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDavid S. MillerJim CromieJason Baron
SeriesA-b T-b A-b
1/5A-b T-b A-b
1/5A-b T-b A-b
2/5A-b T-b A-b
2/5A-b T-b A-b
3/5A-b T-b A-b
3/5A-b T-b A-b
4/5A-b T-b A-b
4/5A-b T-b A-b
5/5A-b T-b A-b
5/5A-b T-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/5] dev_<level> and dynamic_debug cleanups

The recent commit to fix dynamic_debug was a bit unclean. Neaten the style for dynamic_debug.
Reduce the stack use of message logging that uses netdev_printk Add utility functions dev_printk_emit and dev_vprintk_emit for /dev/kmsg.

Joe Perches (5):
dev_dbg/dynamic_debug: Update to use printk_emit, optimize stack netdev_printk/dynamic_netdev_dbg: Directly call printk_emit netdev_printk/netif_printk: Remove a superfluous logging colon
dev: Add dev_vprintk_emit and dev_printk_emit
device and dynamic_debug: Use dev_vprintk_emit and dev_printk_emit

 drivers/base/core.c       |   87 +++++++++++++++++++++++++++++---------------
 include/linux/device.h    |   17 +++++++--
 include/linux/netdevice.h |    3 --
 lib/dynamic_debug.c       |   56 ++++++++++++++++++++++-------
 net/core/dev.c            |   20 +++++++----
 5 files changed, 126 insertions(+), 57 deletions(-)
Signature · 1 line
1.7.8.111.gad25c.dirty