Skip to content

winbond-cir: Fix initialization

Sean Young linux-serial 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v12 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Removed IrDA entries
- Renamed PORT_IR to PORT_8250_CIR
- commit message rewording

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/28250_pnp: do pnp probe before legacy probedrivers/tty/serial/8250/8250.c drivers/tty/serial/8250/8250.h drivers/tty/serial/8250/8250_pnp.c +2 more+41 -310 replies
2/28250: blacklist Winbond CIR portdrivers/tty/serial/8250/8250.c drivers/tty/serial/8250/8250_pnp.c include/linux/serial_core.h+31 -80 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlan Cox
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] winbond-cir: Fix initialization

The serial driver will detect the winbond cir device as a serial port, since it looks exactly like a serial port unless you know what it is from the PNP ID.

v2:
Alan Cox pointed out[1] that the pnp serial probe should be done before the legacy probe and we should keep track of any IR ports during the pnp scan. This is an implementation of that idea.

[1] http://www.spinics.net/lists/linux-serial/msg06757.html

v3:
- Removed IrDA entries
- Renamed PORT_IR to PORT_8250_CIR
- commit message rewording

Diffed against tty-next.

Sean Young (2):
8250_pnp: do pnp probe before legacy probe
8250: blacklist Winbond CIR port

 drivers/tty/serial/8250/8250.c     |   47 ++++++++++++++++++++++++-----------
 drivers/tty/serial/8250/8250.h     |    9 +++++++
 drivers/tty/serial/8250/8250_pnp.c |   31 +++++++++++++----------
 drivers/tty/serial/8250/Kconfig    |   16 ++++++------
 drivers/tty/serial/8250/Makefile   |    5 ++-
 include/linux/serial_core.h        |    3 +-
 6 files changed, 72 insertions(+), 39 deletions(-)
Signature · 1 line
1.7.2.5