Skip to content

block-commit fixes

Jeff Cody qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesIn review
  2. v24 patches 5 repliesSuperseded
  3. v12 patches 14 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4block: make bdrv_find_backing_image compare canonical filenamesblock.c+54 -60 replies
2/4block: in commit, determine base image from the top imageblock/commit.c blockdev.c+11 -190 replies
3/4qemu-iotests: qemu-io tests update for block-commit (040)tests/qemu-iotests/040+2 -20 replies
4/4qemu-iotests: add relative backing file tests for block-commit (040)tests/qemu-iotests/040 tests/qemu-iotests/040.out+104 -20 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric Blake
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/4] block-commit fixes

v2 -> v3 differences:

* Simplified code in patch 2, minor commit rewording
* Made conditional check more valgrind-friendly

v1 -> v2 differences:

* Updated changes to be protocol friendly
* Updated block-commit tests to account for different error message wording
* Updated block-commit tests to add relative backing filename tests
* In bdrv_find_backing_image(), use g_malloc() instead of char arrays

Jeff Cody (4):
block: make bdrv_find_backing_image compare canonical filenames
block: in commit, determine base image from the top image
qemu-iotests: qemu-io tests update for block-commit (040)
qemu-iotests: add relative backing file tests for block-commit (040)

Jeff Cody (4):
block: make bdrv_find_backing_image compare canonical filenames
block: in commit, determine base image from the top image
qemu-iotests: qemu-io tests update for block-commit (040)
qemu-iotests: add relative backing file tests for block-commit (040)

 block.c                    |  60 ++++++++++++++++++++++---
 block/commit.c             |   9 ----
 blockdev.c                 |  21 ++++-----
 tests/qemu-iotests/040     | 106 ++++++++++++++++++++++++++++++++++++++++++++-
 tests/qemu-iotests/040.out |   4 +-
 5 files changed, 171 insertions(+), 29 deletions(-)
Signature · 1 line
1.7.11.4