Skip to content

printk: refactoring

Joe Perches lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest23 patches 8 repliesIn review
  2. v123 patches 7 repliesSuperseded

Changes in v2 from the cover letter

Fix braille.h: _braille_console_setup return value Remove duplicated #define
Add missing #include <linux/uaccess.h>

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23printk: Move to separate directory for easier modificationkernel/Makefile kernel/printk/Makefile kernel/printk/printk.c+3 -30 replies
2/23printk: Add console_cmdline.hkernel/printk/console_cmdline.h kernel/printk/printk.c+18 -90 replies
3/23printk: Move braille console support into separate braille.[ch] filesdrivers/accessibility/braille/braille_console.c kernel/printk/Makefile kernel/printk/braille.c +2 more+117 -330 replies
4/23printk: Use pointer for console_cmdline indexingkernel/printk/printk.c+26 -230 replies
5/23printk: rename struct log to struct printk_logkernel/printk/printk.c+40 -400 replies
6/23printk: Rename log_buf and __LOG_BUF_LENkernel/printk/printk.c+38 -380 replies
7/23printk: Rename log_first and log_next variableskernel/printk/printk.c+75 -750 replies
8/23printk: Rename log_<foo> variables and functionskernel/printk/printk.c+50 -500 replies
9/23printk: Rename enum log_flags to printk_log_flagskernel/printk/printk.c+17 -150 replies
10/23printk: Rename log_wait to printk_log_waitfs/proc/kmsg.c kernel/printk/printk.c+8 -80 replies
11/23printk: Rename logbuf_lock to printk_logbuf_lockkernel/printk/printk.c+51 -510 replies
12/23printk: Rename clear_seq and clear_idx variableskernel/printk/printk.c+17 -170 replies
13/23printk: Remove static from printk_ variableskernel/printk/printk.c+23 -230 replies
14/23printk: Rename LOG_ALIGN to PRINTK_LOG_ALIGNkernel/printk/printk.c+4 -40 replies
15/23printk: Add and use printk_log.hkernel/printk/printk.c kernel/printk/printk_log.h+116 -900 replies
16/23printk: Add printk_log.ckernel/printk/Makefile kernel/printk/printk.c kernel/printk/printk_log.c+150 -1280 replies
17/23printk: Make wait_queue_head_t printk_log_wait externkernel/printk/printk_log.h+1 -00 replies
18/23printk: Rename and move 2 #defines to printk_log.hkernel/printk/printk.c kernel/printk/printk_log.h+16 -140 replies
19/23printk: Move devkmsg bits to separate filekernel/printk/Makefile kernel/printk/devkmsg.c kernel/printk/printk.c+310 -2960 replies
20/23printk: Prefix print_time and msg_print_text with printk_kernel/printk/printk.c kernel/printk/printk_log.h+28 -190 replies
21/23printk: Move functions printk_print_time and printk_msg_print_textkernel/printk/printk.c kernel/printk/printk_log.c+114 -1120 replies
22/23printk: Add printk_syslog.c and .hkernel/printk/Makefile kernel/printk/printk.c kernel/printk/printk_syslog.c +1 more+373 -3470 replies
23/23printk: Move kmsg_dump functions to separate filekernel/printk/Makefile kernel/printk/kmsg_dump.c kernel/printk/printk.c+329 -3180 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH V2 00/23] printk: refactoring

Make printk a bit more readable.

Created directory:
kernel/printk
Created source files:
printk.c Generic printk and console routines
printk_log.[ch] Log buffer routines
printk_syslog.[ch] syslog(2) routines
braille.c Braille console support
devkmsg.c /dev/kmsg support
kmsg_dump.c kmsg_dump support

Changes from v1:
Fix braille.h: _braille_console_setup return value Remove duplicated #define
Add missing #include <linux/uaccess.h>

Joe Perches (23):
printk: Move to separate directory for easier modification
printk: Add console_cmdline.h
printk: Move braille console support into separate braille.[ch] files
printk: Use pointer for console_cmdline indexing
printk: rename struct log to struct printk_log
printk: Rename log_buf and __LOG_BUF_LEN
printk: Rename log_first and log_next variables
printk: Rename log_<foo> variables and functions
printk: Rename enum log_flags to printk_log_flags
printk: Rename log_wait to printk_log_wait
printk: Rename logbuf_lock to printk_logbuf_lock
printk: Rename clear_seq and clear_idx variables
printk: Remove static from printk_ variables
printk: Rename LOG_ALIGN to PRINTK_LOG_ALIGN
printk: Add and use printk_log.h
printk: Add printk_log.c
printk: Make wait_queue_head_t printk_log_wait extern
printk: Rename and move 2 #defines to printk_log.h
printk: Move devkmsg bits to separate file
printk: Prefix print_time and msg_print_text with printk_
printk: Move functions printk_print_time and printk_msg_print_text
printk: Add printk_syslog.c and .h
printk: Move kmsg_dump functions to separate file

 drivers/accessibility/braille/braille_console.c |    9 +-
 fs/proc/kmsg.c                                  |    4 +-
 kernel/Makefile                                 |    3 +-
 kernel/printk.c                                 | 2820 -----------------------
 kernel/printk/Makefile                          |    6 +
 kernel/printk/braille.c                         |   48 +
 kernel/printk/braille.h                         |   48 +
 kernel/printk/console_cmdline.h                 |   14 +
 kernel/printk/devkmsg.c                         |  309 +++
 kernel/printk/kmsg_dump.c                       |  328 +++
 kernel/printk/printk.c                          | 1513 ++++++++++++
 kernel/printk/printk_log.c                      |  263 +++
 kernel/printk/printk_log.h                      |  128 +
 kernel/printk/printk_syslog.c                   |  355 +++
 kernel/printk/printk_syslog.h                   |   13 +
 15 files changed, 3036 insertions(+), 2825 deletions(-)
 delete mode 100644 kernel/printk.c
 create mode 100644 kernel/printk/Makefile
 create mode 100644 kernel/printk/braille.c
 create mode 100644 kernel/printk/braille.h
 create mode 100644 kernel/printk/console_cmdline.h
 create mode 100644 kernel/printk/devkmsg.c
 create mode 100644 kernel/printk/kmsg_dump.c
 create mode 100644 kernel/printk/printk.c
 create mode 100644 kernel/printk/printk_log.c
 create mode 100644 kernel/printk/printk_log.h
 create mode 100644 kernel/printk/printk_syslog.c
 create mode 100644 kernel/printk/printk_syslog.h
Signature · 1 line
1.7.8.112.g3fd21