Skip to content

drm/i915: LVDS/eDP panel, EDID and fixed mode refactoring

Jani Nikula intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drm/i915/lvds: Rename intel_lvds to intel_lvds_encoderdrivers/gpu/drm/i915/intel_lvds.c+61 -681 reply
2/10drm/i915/lvds: Introduce intel_lvds_connectordrivers/gpu/drm/i915/intel_lvds.c+14 -31 reply
3/10drm/i915/lvds: Move the acpi_lid_notifier from drm_i915_private to the connectordrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_lvds.c+17 -171 reply
4/10drm/i915: Backlight setup requires connector so pass it as parameterdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h +2 more+8 -211 reply
5/10drm/i915/lvds: Move some connector specific info across from the encoderdrivers/gpu/drm/i915/intel_lvds.c+42 -411 reply
6/10drm/i915/dp: Initialize eDP fixed mode in intel_dp_initdrivers/gpu/drm/i915/intel_dp.c+25 -281 reply
7/10drm/i915: Create generic intel_panel for LVDS and eDPdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_lvds.c +1 more+27 -21 reply
8/10drm/i915: Move the fixed mode to intel_paneldrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_lvds.c +1 more+49 -321 reply
9/10drm/i915: Do not free the passed EDID in intel_connector_update_modes()drivers/gpu/drm/i915/intel_crt.c drivers/gpu/drm/i915/intel_modes.c+10 -31 reply
10/10drm/i915: Move cached EDID to intel_connectordrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_lvds.c+60 -401 reply

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJesse BarnesChris Wilson
SeriesR-b
1/10R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] drm/i915: LVDS/eDP panel, EDID and fixed mode refactoring

Hi all, this is some LVDS/eDP panel refactoring and cleanup based on Chris Wilson's earlier work and ideas last year [1]. I left out eDP lid notifier based on Jesse's comments [2]; more of Jesse's old review is at [3].

The main high level difference to Chris' patches is that intel_panel and the cached EDID are placed in intel_connector rather than anywhere else. This is because Daniel hinted that we might want to do some more generic EDID caching (indeed, why keep reading the EDID if the display has not been unplugged?). With the EDID and intel_panel in intel_connector, we can add functions to query EDID and modes with transparent caching and fallback to fixed mode when EDID is not available.

BR,
Jani.

[1] http://cgit.freedesktop.org/~ickle/linux-2.6/log/?h=panel-refactor
[2] http://lists.freedesktop.org/archives/intel-gfx/2011-April/010419.html
[3] http://lists.freedesktop.org/archives/intel-gfx/2011-April/thread.html#10401

Jani Nikula (10):
drm/i915/lvds: Rename intel_lvds to intel_lvds_encoder drm/i915/lvds: Introduce intel_lvds_connector drm/i915/lvds: Move the acpi_lid_notifier from drm_i915_private to
the connector
drm/i915: Backlight setup requires connector so pass it as parameter drm/i915/lvds: Move some connector specific info across from the
encoder
drm/i915/dp: Initialize eDP fixed mode in intel_dp_init drm/i915: Create generic intel_panel for LVDS and eDP drm/i915: Move the fixed mode to intel_panel
drm/i915: Do not free the passed EDID in
intel_connector_update_modes()
drm/i915: Move cached EDID to intel_connector

 drivers/gpu/drm/i915/i915_drv.h    |    4 -
 drivers/gpu/drm/i915/intel_crt.c   |    6 +-
 drivers/gpu/drm/i915/intel_dp.c    |  144 +++++++++++++-----------
 drivers/gpu/drm/i915/intel_drv.h   |   20 +++-
 drivers/gpu/drm/i915/intel_lvds.c  |  211 ++++++++++++++++++++----------------
 drivers/gpu/drm/i915/intel_modes.c |    7 +-
 drivers/gpu/drm/i915/intel_panel.c |   32 ++++--
 7 files changed, 241 insertions(+), 183 deletions(-)
Signature · 1 line
1.7.9.5