Skip to content

virtio-rng: fixes

Amit Shah qemu-devel 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 0 repliesNew
  2. v14 patches 6 repliesSuperseded

Changes in v2 from the cover letter

* fix typo in patch 4
* travel back to present, fix cover letter subject line
* add Anthony's reviewed-by tags to patches.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4virtio-rng: use virtqueue_get_avail_bytes, fix migrationhw/virtio-rng.c+12 -640 replies
2/4virtio-rng: remove extra request for entropyhw/virtio-rng.c+0 -70 replies
3/4virtio-rng: disable timer on device removalhw/virtio-rng.c+2 -00 replies
4/4virtio-rng: fix typos, commentshw/virtio-rng.c include/qemu/rng.h+6 -70 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchAnthony Liguori
1/4R-b
2/4R-b
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/4] [For 1.3] virtio-rng: fixes

Hello,

This series fixes a few things, especially the migration support, making it endian-safe.

New in this submission: delete the timer on device remove, else hot-unplug of an rng device could result in a bad access.

The backend should be decoupled on hot-unplug of the virtio-rng device as well, but that's for later.

v2:
* fix typo in patch 4
* travel back to present, fix cover letter subject line
* add Anthony's reviewed-by tags to patches.

Please apply.

Amit Shah (4):
virtio-rng: use virtqueue_get_avail_bytes, fix migration
virtio-rng: remove extra request for entropy
virtio-rng: disable timer on device removal
virtio-rng: fix typos, comments

 hw/virtio-rng.c    | 92 ++++++++++--------------------------------------------
 include/qemu/rng.h |  6 ++--
 2 files changed, 20 insertions(+), 78 deletions(-)
Signature · 1 line
1.8.0