Skip to content

OMAPDSS: Cleanup omap_dss_features

Chandrabhanu Mahapatra linux-fbdev linux-omap 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 4 repliesIn review
  2. v17 patches 8 repliesSuperseded

Changes in v2 from the cover letter

* 1st patch: added comments "in bytes" for new members burst_size_unit and buffer_size_unit
* 2nd patch: renamed register_field to omapdss_reg_field removed definition of enum dispc_feat_reg_field created and initialized struct dispc_reg_fields
* 3rd patch: renamed struct param_range to omapdss_param_range removed definition of enum dispc_range_param created and initialized struct dispc_param_ranges
* 4th patch: removed enum dsi_feat_reg_field
created and initialized struct dsi_reg_fields
* 5th patch: removed enum dsi_range_param
created and initialized struct dsi_param_ranges added member dss_fck corresponding to FEAT_PARAM_DSS_FCK
* 6th patch: removed struct dss_param_range and enum dss_range_param removed functions dss_feat_get_param_min() and dss_feat_get_param_max()
* 7th patch has been removed

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6OMAPDSS: DISPC: Move burst_size and buffer_size to dispc_featuresdrivers/video/omap2/dss/dispc.c drivers/video/omap2/dss/dss_features.c drivers/video/omap2/dss/dss_features.h+17 -360 replies
2/6OMAPDSS: DISPC: Move DISPC specific dss_reg_fields to dispc_featuresdrivers/video/omap2/dss/dispc.c drivers/video/omap2/dss/dss.h drivers/video/omap2/dss/dss_features.c +1 more+89 -642 replies
3/6OMAPDSS: DISPC: Move DISPC specific dss_params to dispc_featuresdrivers/video/omap2/dss/dispc.c drivers/video/omap2/dss/dss.h drivers/video/omap2/dss/dss_features.c +1 more+63 -400 replies
4/6OMAPDSS: DSI: Move DSI specific reg_fields to dsi_featsdrivers/video/omap2/dss/dsi.c drivers/video/omap2/dss/dss_features.c drivers/video/omap2/dss/dss_features.h+114 -322 replies
5/6OMAPDSS: DSI: Move DSI specific dss_params to dsi_featsdrivers/video/omap2/dss/dsi.c drivers/video/omap2/dss/dss_features.c drivers/video/omap2/dss/dss_features.h+69 -440 replies
6/6OMAPDSS: DSS: Add members fld_dispc_clk_switch and dss_fck_maxdrivers/video/omap2/dss/dss.c drivers/video/omap2/dss/dss_features.c drivers/video/omap2/dss/dss_features.h+16 -1140 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH V2 0/6] OMAPDSS: Cleanup omap_dss_features

Hi everyone,
this patch series aims at cleaning up of dss_features.c by moving features to respective submodule drivers.

The 1st patch
* moved struct omap_dss_features members burst_size_unit and buffer_size_unit to dispc_features
The 2nd patch
* added definition of struct omapdss_reg_field
* moved data from dss_reg_fields to dispc_reg_fields
The 3rd patch
* added definition of struct omapdss_param_range
* moved data from dss_param_range to dispc_param_ranges
The 4th patch
* created struct feats and initialized dsi_feats
* moved data from dss_reg_fields to dsi_reg_fields
* created dsi_init_features() to initialize dsi_feats
The 5th patch
* moved data from dss_param_range to dsi_param_range
The 6th patch
* added members fld_dispc_clk_switch and dss_fck_max to struct dss_features and initialized corresponding dss_feats
* removed definition of dss_reg_field and dss_param_range and their respective initializations as omap2_dss_reg_fields, omap3_dss_reg_fields, etc.
* removed members reg_fields and num_reg_fields from struct omap_dss_features
* removed enum dss_feat_reg_field and dss_range_param and corresponding initializations omap2_dss_param_range, omap3_dss_param_range etc.
* removed function dss_feat_get_reg_field(), dss_feat_get_param_min() and dss_feat_get_param_max()

Changes from V1
* 1st patch: added comments "in bytes" for new members burst_size_unit and buffer_size_unit
* 2nd patch: renamed register_field to omapdss_reg_field removed definition of enum dispc_feat_reg_field created and initialized struct dispc_reg_fields
* 3rd patch: renamed struct param_range to omapdss_param_range removed definition of enum dispc_range_param created and initialized struct dispc_param_ranges
* 4th patch: removed enum dsi_feat_reg_field
created and initialized struct dsi_reg_fields
* 5th patch: removed enum dsi_range_param
created and initialized struct dsi_param_ranges added member dss_fck corresponding to FEAT_PARAM_DSS_FCK
* 6th patch: removed struct dss_param_range and enum dss_range_param removed functions dss_feat_get_param_min() and dss_feat_get_param_max()
* 7th patch has been removed

All your comments and suggestions are welcome.

I have based my patches on git://gitorious.org/linux-omap-dss2/linux.git master

Reference Tree:
git://gitorious.org/linux-omap-dss2/chandrabhanus-linux.git dss_cleanup

Regards,
Chandrabhanu

Chandrabhanu Mahapatra (6):
OMAPDSS: DISPC: Move burst_size and buffer_size to dispc_features
OMAPDSS: DISPC: Move DISPC specific dss_reg_fields to dispc_features
OMAPDSS: DISPC: Move DISPC specific dss_params to dispc_features
OMAPDSS: DSI: Move DSI specific reg_fields to dsi_feats
OMAPDSS: DSI: Move DSI specific dss_params to dsi_feats
OMAPDSS: DSS: Add members fld_dispc_clk_switch and dss_fck_max

 drivers/video/omap2/dss/dispc.c        |  218 +++++++++++++++++++++++---------
 drivers/video/omap2/dss/dsi.c          |  206 ++++++++++++++++++++++++++----
 drivers/video/omap2/dss/dss.c          |   22 +++-
 drivers/video/omap2/dss/dss.h          |    8 ++
 drivers/video/omap2/dss/dss_features.c |  212 -------------------------------
 drivers/video/omap2/dss/dss_features.h |   36 ------
 6 files changed, 368 insertions(+), 334 deletions(-)
Signature · 1 line
1.7.10