Skip to content

treewide: Add and use vsprintf extension %pSR

Joe Perches cluster-devel linux-alpha linux-arm-kernel linux-ia64 linux-mm linux-s390 linux-sh linux-um linuxppc-dev lkml 1 version Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest26 patches 32 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/26vsprintf: Add extension %pSR - print_symbol replacementDocumentation/printk-formats.txt lib/vsprintf.c+15 -50 replies
2/26alpha: Convert print_symbol to %pSRarch/alpha/kernel/traps.c+3 -50 replies
3/26arm: Convert print_symbol to %pSRarch/arm/kernel/process.c+2 -20 replies
4/26arm64: Convert print_symbol to %pSRarch/arm64/kernel/process.c+2 -21 reply
5/26avr32: Convert print_symbol to %pSRarch/avr32/kernel/process.c+7 -180 replies
6/26c6x: Convert print_symbol to %pSRarch/c6x/kernel/traps.c+1 -20 replies
7/26ia64: Convert print_symbol to %pSRarch/ia64/kernel/process.c+5 -80 replies
8/26m32r: Convert print_symbol to %pSRarch/m32r/kernel/traps.c+2 -44 replies
9/26mn10300: Convert print_symbol to %pSRarch/mn10300/kernel/traps.c+4 -40 replies
10/26openrisc: Convert print_symbol to %pSRarch/openrisc/kernel/traps.c+2 -50 replies
11/26powerpc: Convert print_symbol to %pSRarch/powerpc/platforms/cell/spu_callbacks.c+5 -73 replies
12/26s390: Convert print_symbol to %pSRarch/s390/kernel/traps.c+16 -121 reply
13/26sh: Convert print_symbol to %pSRarch/sh/kernel/process_32.c+2 -20 replies
14/26um: Convert print_symbol to %pSRarch/um/kernel/sysrq.c+2 -40 replies
15/26unicore32: Convert print_symbol to %pSRarch/unicore32/kernel/process.c+3 -24 replies
16/26x86: Convert print_symbol to %pSRarch/x86/kernel/cpu/mcheck/mce.c arch/x86/kernel/dumpstack.c arch/x86/kernel/process_32.c +2 more+15 -1812 replies
17/26xtensa: Convert print_symbol to %pSRarch/xtensa/kernel/traps.c+2 -40 replies
18/26drivers: base: Convert print_symbol to %pSRdrivers/base/core.c+2 -20 replies
19/26gfs2: Convert print_symbol to %pSRfs/gfs2/glock.c fs/gfs2/trans.c+4 -32 replies
20/26sysfs: Convert print_symbol to %pSRfs/sysfs/file.c+2 -20 replies
21/26irq: Convert print_symbol to %pSRkernel/irq/debug.h+7 -80 replies
22/26smp_processor_id: Convert print_symbol to %pSRlib/smp_processor_id.c+1 -10 replies
23/26mm: Convert print_symbol to %pSRmm/memory.c mm/slab.c+7 -92 replies
24/26xtensa: Convert print_symbol to %pSRDocumentation/filesystems/sysfs.txt Documentation/zh_CN/filesystems/sysfs.txt+4 -40 replies
25/26x86: head_64.S: Use vsprintf extension %pSR not print_symbolarch/x86/kernel/head_64.S+2 -20 replies
26/26kallsyms: Remove print_symbolinclude/linux/kallsyms.h kernel/kallsyms.c+0 -290 replies

Reviews trailers per patch

7 of 26 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChristoph LameterBorislav PetkovHirokazu TakataGuan XuetaoSteven WhitehouseArnd BergmannCatalin MarinasTony Luck
SeriesA-b A-b
1/26
2/26
3/26
4/26A-b
5/26
6/26
7/26
8/26A-b
9/26
10/26
11/26A-b
12/26
13/26
14/26
15/26A-b
16/26A-b
17/26
18/26
19/26A-b
20/26
21/26
22/26
23/26A-b
24/26
25/26
26/26

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v1 thread

Cover letter [TRIVIAL PATCH 00/26] treewide: Add and use vsprintf extension %pSR

Remove the somewhat awkward uses of print_symbol and convert all the existing uses to a new vsprintf pointer type of %pSR.

print_symbol can be interleaved when it is used in a sequence like:

	printk("something: ...");
	print_symbol("%s", addr);
	printk("\n");

Instead use:

	printk("something: %pSR\n", (void *)addr);

Add a new %p[SsFf]R vsprintf extension that can perform the same symbol function/address/offset formatting as print_symbol to reduce the number and styles of message logging functions.

print_symbol used __builtin_extract_return_addr for those architectures like S/390 and SPARC that have offset or masked addressing. %p[FfSs]R uses the same gcc __builtin

Joe Perches (26):
vsprintf: Add extension %pSR - print_symbol replacement
alpha: Convert print_symbol to %pSR
arm: Convert print_symbol to %pSR
arm64: Convert print_symbol to %pSR
avr32: Convert print_symbol to %pSR
c6x: Convert print_symbol to %pSR
ia64: Convert print_symbol to %pSR
m32r: Convert print_symbol to %pSR
mn10300: Convert print_symbol to %pSR
openrisc: Convert print_symbol to %pSR
powerpc: Convert print_symbol to %pSR
s390: Convert print_symbol to %pSR
sh: Convert print_symbol to %pSR
um: Convert print_symbol to %pSR
unicore32: Convert print_symbol to %pSR
x86: Convert print_symbol to %pSR
xtensa: Convert print_symbol to %pSR
drivers: base: Convert print_symbol to %pSR
gfs2: Convert print_symbol to %pSR
sysfs: Convert print_symbol to %pSR
irq: Convert print_symbol to %pSR
smp_processor_id: Convert print_symbol to %pSR
mm: Convert print_symbol to %pSR
xtensa: Convert print_symbol to %pSR
x86: head_64.S: Use vsprintf extension %pSR not print_symbol
kallsyms: Remove print_symbol

 Documentation/filesystems/sysfs.txt         |    4 +-
 Documentation/printk-formats.txt            |    2 +
 Documentation/zh_CN/filesystems/sysfs.txt   |    4 +-
 arch/alpha/kernel/traps.c                   |    8 ++----
 arch/arm/kernel/process.c                   |    4 +-
 arch/arm64/kernel/process.c                 |    4 +-
 arch/avr32/kernel/process.c                 |   25 ++++++-----------------
 arch/c6x/kernel/traps.c                     |    3 +-
 arch/ia64/kernel/process.c                  |   13 ++++-------
 arch/m32r/kernel/traps.c                    |    6 +---
 arch/mn10300/kernel/traps.c                 |    8 +++---
 arch/openrisc/kernel/traps.c                |    7 +----
 arch/powerpc/platforms/cell/spu_callbacks.c |   12 ++++------
 arch/s390/kernel/traps.c                    |   28 +++++++++++++++-----------
 arch/sh/kernel/process_32.c                 |    4 +-
 arch/um/kernel/sysrq.c                      |    6 +---
 arch/unicore32/kernel/process.c             |    5 ++-
 arch/x86/kernel/cpu/mcheck/mce.c            |   13 ++++++-----
 arch/x86/kernel/dumpstack.c                 |    5 +--
 arch/x86/kernel/head_64.S                   |    4 +-
 arch/x86/kernel/process_32.c                |    2 +-
 arch/x86/mm/mmio-mod.c                      |    4 +-
 arch/x86/um/sysrq_32.c                      |    9 ++-----
 arch/xtensa/kernel/traps.c                  |    6 +---
 drivers/base/core.c                         |    4 +-
 fs/gfs2/glock.c                             |    4 +-
 fs/gfs2/trans.c                             |    3 +-
 fs/sysfs/file.c                             |    4 +-
 include/linux/kallsyms.h                    |   18 -----------------
 kernel/irq/debug.h                          |   15 ++++++-------
 kernel/kallsyms.c                           |   11 ----------
 lib/smp_processor_id.c                      |    2 +-
 lib/vsprintf.c                              |   18 ++++++++++++----
 mm/memory.c                                 |    8 +++---
 mm/slab.c                                   |    8 ++----
 35 files changed, 117 insertions(+), 164 deletions(-)
Signature · 1 line
1.7.8.112.g3fd21

Read the cover letter in its thread