virtio-serial: Rework, fix post_load code
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | virtio-serial: use uint32_t to count portshw/ | +2 | 1 reply | |
| 2/4 | virtio-serial: move active ports loading to separate functionhw/ | +55 | 0 replies | |
| 3/4 | virtio-serial: allocate post_load only at load-timehw/ | +38 | 0 replies | |
| 4/4 | virtio-serial: delete timer if active during exithw/ | +1 | 0 replies |
Reviews trailers per patch
None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Alon Levy |
|---|---|
| Series | R-b |
| 1/4 | |
| 2/4 | |
| 3/4 | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH 0/4] virtio-serial: Rework, fix post_load code
This series reworks the post_load code recently introduced to allocate the structures only when required (i.e. only at load time). This helps keep the VirtIOSerial struct clean, and use less RAM.
Also rearrange the code in virtio_serial_load() for easier readability.
Patch 4 fixes a race with the timer going off after a device got hot-unplugged, and patch 1 uses unsigned int (uint32_t) type to count ports, as in the rest of the code.
Please review.
Amit Shah (4):
virtio-serial: use uint32_t to count ports
virtio-serial: move active ports loading to separate function
virtio-serial: allocate post_load only at load-time
virtio-serial: delete timer if active during exit
hw/virtio-serial-bus.c | 150 +++++++++++++++++++++++++++++-------------------- 1 file changed, 89 insertions(+), 61 deletions(-)
Signature · 1 line
1.8.0.2