convert savevm to use qapi and introduce qmp command
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest11 patches 41 repliesIn review
- v311 patches 7 repliesSuperseded
- v212 patches 15 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 13 patches | 7 replies | Superseded |
Changes in v4 from the cover letter
- correct hopefully all error messages
- proper commit message for 'qapi: Convert savevm'
Patches in v4 No applies recorded yet
Reviews trailers per patch
All 11 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake |
|---|---|
| 1/11 | R-b |
| 2/11 | R-b |
| 3/11 | R-b |
| 4/11 | R-b |
| 5/11 | R-b |
| 6/11 | R-b |
| 7/11 | R-b |
| 8/11 | R-b |
| 9/11 | R-b |
| 10/11 | R-b |
| 11/11 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command
This patch series convert the savevm command into qapi and introduce QMP command vm-snapshot-save.
It also rewrite error report for functions used by this command.
The last patch introduce new functionality of savevm that you cannot override existing snapshot without using 'force' parameter.
If non-blocking behaviour of this command is required and we cannot wait until live snapshots will be finished, I could improve this basic command to be non-blocking.
Changes from v3:
- correct hopefully all error messages
- proper commit message for 'qapi: Convert savevm'
Changes from v2:
- correct error messages
- introduce of 'force' option moved to qapi: Convert savevm
- update of return value for used functions
- drop of the speed improve because it isn't actually speed improve
- vm-snapshot-save and savevm now returns snapshot information
Changes from v1:
- rebase on current master branch
- improve the speed of savevm
- name parameter remains optionl for HMP and QMP
Pavel Hrdina (11):
block: add error parameter to bdrv_snapshot_create() and related
functions
block: add error parameter to del_existing_snapshots()
savevm: add error parameter to qemu_savevm_state_begin()
savevm: add error parameter to qemu_savevm_state_iterate()
savevm: add error parameter to qemu_savevm_state_complete()
savevm: add error parameter to qemu_savevm_state()
qapi: Convert savevm
qemu-img: introduce qemu_img_handle_error
block: update return value from bdrv_snapshot_create
savevm: update return value from qemu_savevm_state
savevm: add force parameter to HMP command and return snapshot info
block.c | 24 +++++++----- block/qcow2-snapshot.c | 15 +++++--- block/qcow2.h | 4 +- block/rbd.c | 19 +++++----- block/sheepdog.c | 20 +++++----- hmp-commands.hx | 18 ++++----- hmp.c | 27 ++++++++++++++ hmp.h | 1 + include/block/block.h | 5 ++- include/block/block_int.h | 5 ++- include/sysemu/sysemu.h | 8 ++-- migration.c | 6 +-- qapi-schema.json | 22 +++++++++++ qemu-img.c | 27 ++++++++------ qmp-commands.hx | 43 ++++++++++++++++++++++ savevm.c | 93 ++++++++++++++++++++++++++++------------------- 16 files changed, 235 insertions(+), 102 deletions(-)
Signature · 1 line
1.8.1.4