Python 3 support for git_remote_helpers
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest8 patches 16 repliesIn review
- v28 patches 15 repliesSuperseded
- v18 patches 15 repliesSuperseded
Changes in v3 from the cover letter
- Change reference URL in commit message of patch 4 (git_remote_helpers: Use 2to3 if building with Python 3) to point at Python documentation instead of the Python wiki.
- Add a comment in patch 7 (git-remote-testpy: don't do unbuffered text I/O), as suggested by Sverre.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | git_remote_helpers: Allow building with Python 3git_remote_helpers/ | +1 | 1 reply | |
| 2/8 | git_remote_helpers: fix input when running under Python 3git_remote_helpers/ | +6 | 6 replies | |
| 3/8 | git_remote_helpers: Force rebuild if python version changesgit_remote_helpers/ git_remote_helpers/ | +8 | 1 reply | |
| 4/8 | git_remote_helpers: Use 2to3 if building with Python 3git_remote_helpers/ | +10 | 0 replies | |
| 5/8 | svn-fe: allow svnrdump_sim.py to run with Python 3contrib/ | +2 | 0 replies | |
| 6/8 | git-remote-testpy: hash bytes explicitlygit-remote-testpy.py | +4 | 21 replies | |
| 7/8 | git-remote-testpy: don't do unbuffered text I/Ogit-remote-testpy.py | +7 | 0 replies | |
| 8/8 | git-remote-testpy: call print as a functiongit-remote-testpy.py | +14 | 0 replies |
Reviews trailers per patch
3 of 8 patches have a Reviewed-by or Acked-by.
| Patch | Sverre Rabbelier | Michael Haggerty |
|---|---|---|
| 1/8 | A-b | |
| 2/8 | ||
| 3/8 | ||
| 4/8 | A-b | |
| 5/8 | ||
| 6/8 | Helped-by Helped-by | |
| 7/8 | ||
| 8/8 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/8] Python 3 support for git_remote_helpers
This series does enough so that everything except git-p4 runs under Python 3.
As discussed with Pete, it may not make sense to change git-p4 to support Python 3 until Perforce's Python output mode is changed. So does it make sense to merge this now and say "use Python 2 if you want git-p4"?
Changes since v2:
- Change reference URL in commit message of patch 4 (git_remote_helpers: Use 2to3 if building with Python 3) to point at Python documentation instead of the Python wiki.
- Add a comment in patch 7 (git-remote-testpy: don't do unbuffered text I/O), as suggested by Sverre.
John Keeping (8):
git_remote_helpers: Allow building with Python 3
git_remote_helpers: fix input when running under Python 3
git_remote_helpers: Force rebuild if python version changes
git_remote_helpers: Use 2to3 if building with Python 3
svn-fe: allow svnrdump_sim.py to run with Python 3
git-remote-testpy: hash bytes explicitly
git-remote-testpy: don't do unbuffered text I/O
git-remote-testpy: call print as a function
contrib/svn-fe/svnrdump_sim.py | 4 ++-- git-remote-testpy.py | 46 +++++++++++++++++++++----------------- git_remote_helpers/.gitignore | 1 + git_remote_helpers/Makefile | 10 +++++++-- git_remote_helpers/git/importer.py | 9 +++++--- git_remote_helpers/setup.py | 10 +++++++++ 6 files changed, 52 insertions(+), 28 deletions(-)
Signature · 1 line
1.8.1.353.gc992d5a.dirty