Skip to content

Fixes for INCOMPATIBLE_LICENSE handling

Christopher Larson openembedded-core 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6license.bbclass: check LICENSE_pkg, not LICENSE_pn-pkgmeta/classes/license.bbclass+1 -20 replies
2/6license: correct re.search/fnmatch indentationmeta/classes/license.bbclass+4 -40 replies
3/6license.bbclass: cleanly handle invalid licenses in incompatible_licensemeta/classes/license.bbclass+4 -10 replies
4/6linux-firmware: use LICENSEs which can actually be parsedmeta/recipes-kernel/linux-firmware/linux-firmware_git.bb+6 -70 replies
5/6base.bbclass: use debug messages for INCOMPATIBLE_LICENSEmeta/classes/base.bbclass+3 -30 replies
6/6base.bbclass: improve the incompatible license logic a bitmeta/classes/base.bbclass+1 -22 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBeth Flanagan
SeriesA-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] Fixes for INCOMPATIBLE_LICENSE handling

From: Christopher Larson <[email protected]>

This fixes a number of bugs spotted while trying to use INCOMPATIBLE_LICENSE = "*GPLv3", and also while experimenting with a recipe whose LICENSE includes GPLv3, but whose packages do not. In addition, it reduces the message spam by switching the license incompatibility messages to debug.

Note: there's still one remaining bug I noticed, the wildcard support which was added is not very well supported in concert with the host tools exclusion variables. It asks for an spdx version of "*GPLv3", gets nothing but itself, and tries to look up whitelists for that string. This is not addressed by this patch series, but I mention it here for awareness, and also a reminder to myself to look in to it.

The following changes since commit 6080d1dc719c38fd97c2abd38e0ad938fbf6f452:

connman: fixed init script so connman can runs over nfs (2013-01-15 08:09:30 +0000)

are available in the git repository at:

https://github.com/kergoth/oe-core incompatible-license

for you to fetch changes up to 5cb12f38b2ac74ea118b58888a0c37f63917fbfa:

base.bbclass: improve the incompatible license logic a bit (2013-01-15 12:48:51 -0700)

----------------------------------------------------------------
Christopher Larson (6):
license.bbclass: check LICENSE_pkg, not LICENSE_pn-pkg
license: correct re.search/fnmatch indentation license.bbclass: cleanly handle invalid licenses in incompatible_license
linux-firmware: use LICENSEs which can actually be parsed base.bbclass: use debug messages for INCOMPATIBLE_LICENSE base.bbclass: improve the incompatible license logic a bit

 meta/classes/base.bbclass                                |  9 ++++-----
 meta/classes/license.bbclass                             | 16 +++++++++-------
 meta/recipes-kernel/linux-firmware/linux-firmware_git.bb | 13 ++++++-------
 3 files changed, 19 insertions(+), 19 deletions(-)

Christopher Larson (6):
license.bbclass: check LICENSE_pkg, not LICENSE_pn-pkg
license: correct re.search/fnmatch indentation license.bbclass: cleanly handle invalid licenses in
incompatible_license
linux-firmware: use LICENSEs which can actually be parsed base.bbclass: use debug messages for INCOMPATIBLE_LICENSE base.bbclass: improve the incompatible license logic a bit

 meta/classes/base.bbclass                                |  9 ++++-----
 meta/classes/license.bbclass                             | 16 +++++++++-------
 meta/recipes-kernel/linux-firmware/linux-firmware_git.bb | 13 ++++++-------
 3 files changed, 19 insertions(+), 19 deletions(-)
Signature · 1 line
1.8.0.3