Skip to content

RFC Storing yocto settings as target profiles

Timo Mueller yocto 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 RFC Latest17 patches 1 replyIn review
  2. v3 RFC18 patches 3 repliesSuperseded
  3. v2 RFC18 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC17 patches1 replySuperseded

Changes in v4 from the cover letter

<snip>
First of all I've fixed the issues with the patches (duplicate method, missing fix for NewYoctoCProjectTemplate.java).

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17plugins/sdk.ide: Removed unused messageplugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoSDKMessages.properties+0 -10 replies
2/17plugins/sdk.ide: Extract labels to private membersplugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoUISetting.java+7 -70 replies
3/17plugins/sdk.ide: Add method to enable and disable formplugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoUISetting.java+44 -00 replies
4/17plugins/sdk.ide: Set value of target array on input changeplugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoUISetting.java+2 -00 replies
5/17plugins/sdk.ide: Changed method signature to be more consistentplugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoSDKUtils.java plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/preferences/YoctoSDKProjectPropertyPage.java+2 -20 replies
6/17plugins/sdk.ide: Create UI element for managing target profiles.plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileElement.java plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileSetting.java plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoSDKMessages.properties +1 more+208 -00 replies
7/17plugins/sdk.ide: Modified preferences storage to support profiles.plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoSDKPlugin.java plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoSDKProjectNature.java plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoSDKUtils.java +5 more+99 -530 replies
8/17plugins/sdk.ide: Set profile on selection changeplugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileSetting.java+23 -00 replies
9/17plugins/sdk.ide: Add method to allow storing the current settingsplugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileSetting.java+8 -10 replies
10/17plugins/sdk.ide: Add UI method to create a new profileplugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileSetting.java plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoSDKMessages.properties plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/preferences/ProfileNameInputValidator.java +1 more+142 -10 replies
11/17plugins/sdk.ide: Add UI method to delete a profileplugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileSetting.java plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoSDKMessages.properties+38 -00 replies
12/17plugins/sdk.ide: Add UI method to rename a profileplugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileSetting.java plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoSDKMessages.properties+40 -00 replies
13/17plugins/sdk.ide: Add method to change values of the preference pageplugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileSetting.java+4 -00 replies
14/17plugins/sdk.ide: Add method to rename a profile and its preference storeplugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileSetting.java+4 -00 replies
15/17plugins/sdk.ide: Add method to delete a profileplugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileSetting.java+4 -00 replies
16/17plugins/sdk.ide: Use profiles for the preference pageplugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/preferences/YoctoSDKPreferencePage.java+22 -60 replies
17/17plugins/sdk.ide: Added profile UI to the preference pageplugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/preferences/YoctoSDKPreferencePage.java+3 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [RFC v4 00/17][eclipse-poky] Storing yocto settings as target profiles

From: Timo Mueller <[email protected]>

Hi,

I removed the last patch that was moving the "Save as ..." button to the bottom. So now it is located beneath the dropdown box. I also changed the message in the profile deletion dialog to only ask if the user really wants to delete the profile.

From RFC v3:
<snip>
First of all I've fixed the issues with the patches (duplicate method, missing fix for NewYoctoCProjectTemplate.java).

I also changed the functionality of the "new" button according to Jessica's feedback. The logic is changed to a "Save as ..." approach. If the button is clicked the current values of the form are checked. If these are valid, the user can enter a name to store them as a new profile.
</snip>

From the original cover letter:
<snip>
currently the yocto settings can be changed globally through eclipse's preferences or locally in the project properties. But the standard configuration stored in the global preferences sometimes changes, e.g. if a new version of the toolchain or the sysroot is released.
If you change the global settings to the updated toolchain or sysroot your old working configuration is gone. If you want to reuse this configuration at a later point in time you have to (remember and) re-enter everthing. This patch set introduces the possiblity to store a configuration under a unique name, a so called target profile, and be able to select the default target profile that is used for new projects.
Building upon this change the target profiles could later also be used in the project settings and be able to quickly build and debug your software for different hard- and software combinations.
</snip>

Best regards,
Timo

Atanas Gegov (4):
plugins/sdk.ide: Extract labels to private members plugins/sdk.ide: Add method to enable and disable form plugins/sdk.ide: Set value of target array on input change plugins/sdk.ide: Create UI element for managing target profiles.

Timo Mueller (13):
plugins/sdk.ide: Removed unused message
plugins/sdk.ide: Changed method signature to be more consistent plugins/sdk.ide: Modified preferences storage to support profiles. plugins/sdk.ide: Set profile on selection change plugins/sdk.ide: Add method to allow storing the current settings plugins/sdk.ide: Add UI method to create a new profile plugins/sdk.ide: Add UI method to delete a profile plugins/sdk.ide: Add UI method to rename a profile plugins/sdk.ide: Add method to change values of the preference page plugins/sdk.ide: Add method to rename a profile and its preference
store
plugins/sdk.ide: Add method to delete a profile plugins/sdk.ide: Use profiles for the preference page plugins/sdk.ide: Added profile UI to the preference page

 .../src/org/yocto/sdk/ide/YoctoProfileElement.java | 104 ++++++++++
 .../src/org/yocto/sdk/ide/YoctoProfileSetting.java | 229 +++++++++++++++++++++
 .../org/yocto/sdk/ide/YoctoSDKMessages.properties  |  19 +-
 .../src/org/yocto/sdk/ide/YoctoSDKPlugin.java      |   9 +
 .../org/yocto/sdk/ide/YoctoSDKProjectNature.java   |  10 +-
 .../src/org/yocto/sdk/ide/YoctoSDKUtils.java       |  62 ++++--
 .../src/org/yocto/sdk/ide/YoctoUISetting.java      |  60 +++++-
 .../sdk/ide/preferences/PreferenceConstants.java   |   5 +
 .../sdk/ide/preferences/PreferenceInitializer.java |  22 +-
 .../ide/preferences/ProfileNameInputValidator.java |  63 ++++++
 .../ide/preferences/YoctoSDKPreferencePage.java    | 112 +++++++---
 .../preferences/YoctoSDKProjectPropertyPage.java   |   6 +-
 .../sdk/ide/wizard/NewYoctoCProjectTemplate.java   |   7 +-
 13 files changed, 643 insertions(+), 65 deletions(-)
 create mode 100644 plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileElement.java
 create mode 100644 plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileSetting.java
 create mode 100644 plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/preferences/ProfileNameInputValidator.java
Signature · 1 line
1.7.11.7