Skip to content

Make Git compile warning-free with Clang

John Keeping git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fix clang -Wtautological-compare with unsigned enumgrep.c grep.h+4 -21 reply
2/3combine-diff: suppress a clang warningcombine-diff.c+1 -113 replies
3/3builtin/apply: tighten (dis)similarity index parsingbuiltin/apply.c+6 -41 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Make Git compile warning-free with Clang

The first two patches here were sent to the list before but seem to have got lost in the noise [1][2]. The final one is new but was prompted by discussion in the same thread.

After applying all of these patches, I don't see any warnings compiling Git with Clang 3.2.

[1] http://article.gmane.org/gmane.comp.version-control.git/213817
[2] http://article.gmane.org/gmane.comp.version-control.git/213849

Antoine Pelisse (1):
fix clang -Wtautological-compare with unsigned enum

John Keeping (2):
combine-diff: suppress a clang warning builtin/apply: tighten (dis)similarity index parsing

 builtin/apply.c | 10 ++++++----
 combine-diff.c  |  2 +-
 grep.c          |  3 ++-
 grep.h          |  3 ++-
 4 files changed, 11 insertions(+), 7 deletions(-)
Signature · 1 line
1.8.1.2