Skip to content

textconv for show and grep

Michael J Gruber git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 26 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4show: obey --textconv for blobsbuiltin/log.c+21 -311 replies
2/4cat-file: do not die on --textconv without textconv filtersbuiltin/cat-file.c t/t8007-cat-file-textconv.sh+10 -194 replies
3/4grep: allow to use textconv filtersbuiltin/grep.c grep.c grep.h+89 -142 replies
4/4grep: obey --textconv for the case rev:pathbuiltin/grep.c object.c object.h+28 -118 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC/PATCH 0/4] textconv for show and grep

This min series aims at completing the textconv support of user facing commands. It is RFC for lack of documentation and tests, to check whether we really want to go in that direction (I do).

1/4 covers the missing textconv support in the "blob case" of "git show", which should be (and then is) analogous to "cat-file" and "diff".

2/4 remedies an oddity of "git cat-file --textconv", which errored out when there is no textconv filter rather than giving an unfiltered blob (like every other textconv aware command).

3/4 implements "--textconv" for "git grep" sans the blob case; the code is all Jeff's.

4/4 adds blob support to 3/4 (the "rev:path" case).

3 and 4 can be squashed, of course.

Now I'm quite a happy differ/shower/grepper with my latin1 and OO files ;)

Jeff King (1):
grep: allow to use textconv filters

Michael J Gruber (3):
show: obey --textconv for blobs
cat-file: do not die on --textconv without textconv filters
grep: obey --textconv for the case rev:path

 builtin/cat-file.c           |   9 ++--
 builtin/grep.c               |  13 +++---
 builtin/log.c                |  24 +++++++++--
 grep.c                       | 100 +++++++++++++++++++++++++++++++++++++------
 grep.h                       |   1 +
 object.c                     |  26 ++++++++---
 object.h                     |   2 +
 t/t8007-cat-file-textconv.sh |  20 +++------
 8 files changed, 148 insertions(+), 47 deletions(-)
Signature · 1 line
1.8.1.2.752.g32d147e