fix kernel crash with macvtap on top of LRO
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 18 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | ixgbe: fix gso typedrivers/ | +6 | 1 reply | |
| 2/2 | qlcnic: set gso_typedrivers/ | +6 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] fix kernel crash with macvtap on top of LRO
At the moment, macvtap crashes are observed if macvtap is attached to an interface with LRO enabled.
The crash in question is BUG() in macvtap_skb_to_vnet_hdr. This happens because several drivers set gso_size but not gso_type in incoming skbs.
The following patches fix this for
Additionally, cbf1de72324a8105ddcc3d9ce9acbc613faea17e is required to fix this for broadcom - would it make sense to cherry-pick this patch into 3.8?
I tested that the patch fixes the crash for ixgbe but don't have qlogic hardware to fix. I also only tested TCP.
Feedback wellcome.
Michael S. Tsirkin (2):
ixgbe: fix gso type
qlcnic: set gso_type
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 ++++++-- drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 7 ++++++- 2 files changed, 12 insertions(+), 3 deletions(-)
Signature · 1 line
MST