Skip to content

Improve "git log --graph" output of merges

John Keeping git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6graph: output padding for merge subsequent parentsgraph.c+10 -01 reply
2/6diff: write prefix to the correct filediff.c+1 -10 replies
3/6diff.c: make constant string arguments constdiff.c+4 -20 replies
4/6diff: add diff_line_prefix functiondiff.c diff.h+13 -00 replies
5/6diff.c: use diff_line_prefix() where applicablediff.c+20 -950 replies
6/6combine-diff.c: teach combined diffs about line prefixcombine-diff.c+30 -170 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] Improve "git log --graph" output of merges

This series changes a couple of places that do not currently indent their output when being shown with a graph.

The first patch was already posted [1] and addresses the output of "git log --graph -c -p". Patch 2 is an independent fix I noticed while working on the later patches.

Patches 3-5 introduce a helper function and change existing sites using diff_options->output_prefix to use it, resulting in a net reduction by about 60 lines. There is no functional change here.

The final patch uses the helper introduced in patch 4 to make combined diffs should the output prefix before each line. This affects the output of "git log --graph --cc [-p|--raw]".

[1] http://article.gmane.org/gmane.comp.version-control.git/215630

John Keeping (6):
graph: output padding for merge subsequent parents
diff: write prefix to the correct file diff.c: make constant string arguments const
diff: add diff_line_prefix function
diff.c: use diff_line_prefix() where applicable combine-diff.c: teach combined diffs about line prefix

 combine-diff.c |  47 +++++++++++++--------
 diff.c         | 131 +++++++++++++++------------------------------------------
 diff.h         |   3 ++
 graph.c        |  10 +++++
 4 files changed, 77 insertions(+), 114 deletions(-)
Signature · 1 line
1.8.1.2