Skip to content

Improvements for ghes_edac

Mauro Carvalho Chehab lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ghes_edac: remove GHES_PFX macrodrivers/edac/ghes_edac.c+15 -130 replies
2/6ghes_edac: add a MAINTAINERS entry and copyrightsMAINTAINERS drivers/edac/ghes_edac.c+18 -00 replies
3/6edac: put all arguments for the raw error handling call into a structdrivers/edac/edac_core.h drivers/edac/edac_mc.c drivers/edac/ghes_edac.c +1 more+122 -961 reply
4/6ghes_edac: Make it compliant with UEFI spec 2.3.1drivers/edac/ghes_edac.c+173 -150 replies
5/6edac: add support on ras_event for error type "Info"include/linux/edac.h include/ras/ras_event.h+16 -30 replies
6/6ghes_edac: Fix RAS tracingdrivers/edac/edac_mc.c drivers/edac/ghes_edac.c+23 -90 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchBorislav Petkov
1/6
2/6
3/6A-b
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH EDAC 0/6] Improvements for ghes_edac

This patch series complements the previous one sent:

	http://comments.gmane.org/gmane.linux.kernel/1442178

It contains:

- a patch removing the GHES_PFX macro, as requested by Joe Perches;
- a patch adding copyright notes and an entry at MAINTAINERS for the new driver;
- a patch suggested by Borislav moving the error description to an structure;
- 3 patches improving the error report for GHES-driven errors.

Patches were tested using a 4 cores machine.

With the patches, a GHES error like this one:

{1}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 0 {1}[Hardware Error]: APEI generic hardware error status {1}[Hardware Error]: severity: 2, corrected
{1}[Hardware Error]: section: 0, severity: 2, corrected {1}[Hardware Error]: flags: 0x01
{1}[Hardware Error]: primary
{1}[Hardware Error]: section_type: memory error
{1}[Hardware Error]: error_status: 0x0000000000000400 {1}[Hardware Error]: node: 3
{1}[Hardware Error]: card: 0
{1}[Hardware Error]: module: 1
{1}[Hardware Error]: device: 0
{1}[Hardware Error]: error_type: 18, unknown

Was properly mapped to EDAC printk engine as:

EDAC MC0: 1 CE reserved error (18) on unknown label (node:3 card:0 module:1 page:0x0 offset:0x0 grain:0 syndrome:0x0 - status(0x0000000000000400): Storage error in memory (DRAM))

And to the corresponding RAS trace event:

mc_event: 1 Corrected error: reserved error (18) on unknown label (mc:0 location:-1:-1:-1 address:0x00000000 grain:1 syndrome:0x00000000 APEI location: node:3 card:0 module:1 status(0x0000000000000400): Storage error in memory (DRAM))

Mauro Carvalho Chehab (6):
ghes_edac: remove GHES_PFX macro
ghes_edac: add a MAINTAINERS entry and copyrights
edac: put all arguments for the raw error handling call into a struct
ghes_edac: Make it compliant with UEFI spec 2.3.1
edac: add support on ras_event for error type "Info"
ghes_edac: Fix RAS tracing

 MAINTAINERS              |   7 ++
 drivers/edac/edac_core.h |  16 +--
 drivers/edac/edac_mc.c   | 126 ++++++++++--------------
 drivers/edac/ghes_edac.c | 249 +++++++++++++++++++++++++++++++++++++++++------
 include/linux/edac.h     |  71 ++++++++++++++
 include/ras/ras_event.h  |   4 +-
 6 files changed, 352 insertions(+), 121 deletions(-)
Signature · 1 line
1.8.1.2