Refactor handling of SDK check errors
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | plugins/sdk.ide: Move SDK check functionality to separate classplugins/ plugins/ plugins/ +4 more | +229 | 0 replies | |
| 2/5 | plugins/sdk.ide: Refactored the construction of mesages with SDKCheckResultsplugins/ plugins/ | +99 | 0 replies | |
| 3/5 | plugins/sdk.ide: Show SDK check errors in message areaplugins/ plugins/ plugins/ | +97 | 0 replies | |
| 4/5 | plugins/sdk.ide: Removed validation from setCurrentInputplugins/ | +0 | 0 replies | |
| 5/5 | plugins/sdk.ide: Use standard error dialog to show SDK check errorsplugins/ | +7 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5][eclipse-poky] Refactor handling of SDK check errors
From: Timo Mueller <[email protected]>
Hi,
I tried to display the messages resulting from validating the YoctoUISettings in the message area of the properties/preference pages instead of showing a dialog. This led to some refactoring of the validation functionality and also the messages.
If for example the user entered a SDK toolchain directory that doesn't exist in the global preferences a dialog will show up showing the error and telling him how he can do "IDE-wide settings". As he is currently trying to do "IDE-wide settings" this advice is not really necessary and the dialog can be really annoying.
I split up the messages into a one line error message and an advice. This message can be shown in the page's message area instead of opening a dialog with every configuration error. The advice can still be used when we want to show a dialog to help the user, e.g. when creating a new project.
On a side note I reactivated the YoctoSDKChecker class and moved all the validation code from the utils, getting rid of some duplicated and inconsistent code.
Best regards,
Timo
PS: This patch set is based on "plugins/sdk.ide: Remove profile edit buttons from property page"
Timo Mueller (5):
plugins/sdk.ide: Move SDK check functionality to separate class plugins/sdk.ide: Refactored the construction of mesages with
SDKCheckResults
plugins/sdk.ide: Show SDK check errors in message area plugins/sdk.ide: Removed validation from setCurrentInput plugins/sdk.ide: Use standard error dialog to show SDK check errors
.../src/org/yocto/sdk/ide/YoctoSDKChecker.java | 372 +++++++++++---------- .../org/yocto/sdk/ide/YoctoSDKMessages.properties | 42 ++- .../org/yocto/sdk/ide/YoctoSDKProjectNature.java | 9 +- .../src/org/yocto/sdk/ide/YoctoSDKUtils.java | 255 -------------- .../src/org/yocto/sdk/ide/YoctoUISetting.java | 47 +-- .../ide/preferences/YoctoSDKPreferencePage.java | 84 +++-- .../preferences/YoctoSDKProjectPropertyPage.java | 87 +++-- .../sdk/ide/wizard/NewYoctoCProjectTemplate.java | 18 +- 8 files changed, 344 insertions(+), 570 deletions(-)
Signature · 1 line
1.7.11.7