Skip to content

chardev flow control

Amit Shah qemu-devel 1 version Applied

Status from this message: Applied. Thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 11 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/20char-socket: fix error reportingutil/qemu-sockets.c+4 -00 replies
2/20qemu-char: remove dead/confusing logic with nb_stdio_clientsqemu-char.c+30 -1060 replies
3/20char: add IOWatchPoll supportqemu-char.c+140 -05 replies
4/20qemu-char: convert fd_chr to use a GIOChannelqemu-char.c+62 -410 replies
5/20qemu-char: convert pty to GIOChannelqemu-char.c+27 -170 replies
6/20qemu-char: convert UDP to GIOChannelqemu-char.c+57 -110 replies
7/20qemu-char: tcp: make use GIOChannelqemu-char.c+42 -180 replies
8/20qemu-char: add watch supportinclude/char/char.h qemu-char.c+35 -10 replies
9/20qemu-char: add pty watchqemu-char.c+7 -00 replies
10/20char: add gio watch fn for tcp backendsqemu-char.c+7 -00 replies
11/20qemu-char: use a glib timeout instead of qemu-timerqemu-char.c+45 -234 replies
12/20qemu-char: remove use of QEMUTimer in favor of glib idle functioninclude/char/char.h qemu-char.c+6 -80 replies
13/20qemu-char: make char drivers dynamically registerableinclude/char/char.h qemu-char.c+68 -440 replies
14/20qemu-char: move spice registration to spice-qemu-char.cqemu-char.c spice-qemu-char.c+10 -60 replies
15/20qemu-char: move baum registration to baum.chw/baum.c hw/baum.h qemu-char.c +1 more+8 -360 replies
16/20qemu-char: move msmouse registeration to msmouse.chw/msmouse.c hw/msmouse.h qemu-char.c+9 -110 replies
17/20qemu-char: move text console init to console.cqemu-char.c ui/console.c+7 -11 reply
18/20serial: add flow control to transmithw/serial.c hw/serial.h+11 -190 replies
19/20virtio: console: add flow controlhw/virtio-console.c+13 -00 replies
20/20virtio-serial: make flow control explicit in virtio-consolehw/virtio-console.c hw/virtio-serial-bus.c+10 -260 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/20] chardev flow control

Changes from Anthony's earlier series:
* Added patch 20 that makes flow control explicit in virtio-console
* Fixed compile error in patch 13, "qemu-char: make char drivers dynamically registerable", which had a wrong 'fix' in unrelated patch 16.
* rebased to master

Please apply.

Orig. message from Anthony for this series:

This series implements an idea from Paolo to introduce flow control in the char layer by converting all char backends to use GIOChannels internally. Then we can just use the existing IO watch support in glib to implement flow control.

This is based on a rebased version of an old series of mine plus a number of improvements from Amit Shah.

Amit Shah (3):
char: add gio watch fn for tcp backends
virtio: console: add flow control
virtio-serial: make flow control explicit in virtio-console

Anthony Liguori (17):
char-socket: fix error reporting
qemu-char: remove dead/confusing logic with nb_stdio_clients
char: add IOWatchPoll support
qemu-char: convert fd_chr to use a GIOChannel
qemu-char: convert pty to GIOChannel
qemu-char: convert UDP to GIOChannel
qemu-char: tcp: make use GIOChannel
qemu-char: add watch support
qemu-char: add pty watch
qemu-char: use a glib timeout instead of qemu-timer
qemu-char: remove use of QEMUTimer in favor of glib idle function
qemu-char: make char drivers dynamically registerable
qemu-char: move spice registration to spice-qemu-char.c
qemu-char: move baum registration to baum.c
qemu-char: move msmouse registeration to msmouse.c
qemu-char: move text console init to console.c
serial: add flow control to transmit

 hw/baum.c              |   9 +-
 hw/baum.h              |  30 --
 hw/msmouse.c           |  10 +-
 hw/msmouse.h           |   7 -
 hw/serial.c            |  28 +-
 hw/serial.h            |   2 -
 hw/virtio-console.c    |  28 +-
 hw/virtio-serial-bus.c |  19 +-
 include/char/char.h    |   8 +-
 qemu-char.c            | 763 ++++++++++++++++++++++++++++++++-----------------
 spice-qemu-char.c      |  10 +
 ui/console.c           |   7 +
 util/qemu-sockets.c    |   4 +
 vl.c                   |   1 -
 14 files changed, 578 insertions(+), 348 deletions(-)
 delete mode 100644 hw/baum.h
 delete mode 100644 hw/msmouse.h
Signature · 1 line
1.8.1.2