Skip to content

Improve difftool --dir-diff tests

John Keeping git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3t7800: don't hide grep outputt/t7800-difftool.sh+17 -272 replies
2/3t7800: fix tests when difftool uses --no-symlinkst/t7800-difftool.sh+12 -124 replies
3/3t7800: run --dir-diff tests with and without symlinkst/t7800-difftool.sh+15 -41 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Improve difftool --dir-diff tests

How about doing this?

The first patch is a cleanup as suggested by Johannes[1], the second fixes the test failure on Windows and the third makes the test behaviour more explicit and would have helped to detect this issue earlier.

[1/3] t7800: don't hide grep output
[2/3] t7800: fix tests when difftool uses --no-symlinks [3/3] t7800: run --dir-diff tests with and without symlinks

 t/t7800-difftool.sh | 71 +++++++++++++++++++++++++++--------------------------
 1 file changed, 36 insertions(+), 35 deletions(-)
Signature · 1 line
1.8.2.324.ga64ebd9