Skip to content

Use test_config

Yann Droneaud git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15t4018: remove test_config implementationt/t4018-diff-funcname.sh+0 -50 replies
2/15t7810: remove test_config implementationt/t7810-grep.sh+0 -50 replies
3/15t7811: remove test_config implementationt/t7811-grep-open.sh+0 -50 replies
4/15t3400: use test_config to set/unset git config variablest/t3400-rebase.sh+1 -20 replies
5/15t4304: use test_config to set/unset git config variablest/t3404-rebase-interactive.sh+1 -20 replies
6/15t4034: use test_config/test_unconfig to set/unset git config variablest/t4034-diff-words.sh+3 -40 replies
7/15t4202: use test_config/test_unconfig to set/unset git config variablest/t4202-log.sh+8 -200 replies
8/15t5520: use test_config to set/unset git config variablest/t5520-pull.sh+4 -80 replies
9/15t5541: use test_config to set/unset git config variablest/t5541-http-push.sh+1 -20 replies
10/15t7500: use test_config to set/unset git config variablest/t7500-commit.sh+2 -40 replies
11/15t7502: use test_config to set/unset git config variablest/t7502-commit.sh+3 -50 replies
12/15t7508: use test_config to set/unset git config variablest/t7508-status.sh+16 -300 replies
13/15t7600: use test_config to set/unset git config variablest/t7600-merge.sh+26 -340 replies
14/15t9500: use test_config to set/unset git config variablest/t9500-gitweb-standalone-no-errors.sh+1 -20 replies
15/15t7502: remove clear_configt/t7502-commit.sh+6 -261 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/15] Use test_config

Please find some patches to use test_config/test_unconfig

Instead of using construct such as:
test_when_finished "git config --unset <key>"
git config <key> <value>
uses
test_config <key> <value>
The latter takes care of removing <key> at the end of the test.

Additionally, instead of
git config <key> ""
or
git config --unset <key>
uses
test_unconfig <key>
The latter doesn't failed if <key> is not defined.

Patch "t7600: use test_config to set/unset git config variables" is more important than the other and must be carefully reviewed regarded to the --no-log --no-ff behavior.

Others patches are fairly simple.

Testsuite results are the same after the patches. Tested against master, 7b592fadf1e23b10b913e0771b9f711770597266

Yann Droneaud (15):
t4018: remove test_config implementation
t7810: remove test_config implementation
t7811: remove test_config implementation
t3400: use test_config to set/unset git config variables
t4304: use test_config to set/unset git config variables
t4034: use test_config/test_unconfig to set/unset git config
variables
t4202: use test_config/test_unconfig to set/unset git config
variables
t5520: use test_config to set/unset git config variables
t5541: use test_config to set/unset git config variables
t7500: use test_config to set/unset git config variables
t7502: use test_config to set/unset git config variables
t7508: use test_config to set/unset git config variables
t7600: use test_config to set/unset git config variables
t9500: use test_config to set/unset git config variables
t7502: remove clear_config

 t/t3400-rebase.sh                      |  3 +-
 t/t3404-rebase-interactive.sh          |  3 +-
 t/t4018-diff-funcname.sh               |  5 ---
 t/t4034-diff-words.sh                  |  7 ++--
 t/t4202-log.sh                         | 28 +++++-----------
 t/t5520-pull.sh                        | 12 +++----
 t/t5541-http-push.sh                   |  3 +-
 t/t7500-commit.sh                      |  6 ++--
 t/t7502-commit.sh                      | 40 +++++------------------
 t/t7508-status.sh                      | 46 +++++++++-----------------
 t/t7600-merge.sh                       | 60 +++++++++++++++-------------------
 t/t7810-grep.sh                        |  5 ---
 t/t7811-grep-open.sh                   |  5 ---
 t/t9500-gitweb-standalone-no-errors.sh |  3 +-
 14 files changed, 72 insertions(+), 154 deletions(-)
Signature · 1 line
1.7.11.7