Skip to content

virtio: console: add locking around control out-vq

Amit Shah virtualization 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesIn review
  2. v12 patches 9 repliesSuperseded

Changes in v2 from the cover letter

* Use spin_lock instead of spin_lock_irq. Pointed out by Wanlong Gao.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2virtio: console: rename cvq_lock to c_ivq_lockdrivers/char/virtio_console.c+9 -81 reply
2/2virtio: console: add locking around c_ovq operationsdrivers/char/virtio_console.c+5 -03 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchWanlong Gao
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] virtio: console: add locking around control out-vq

The in-vq operations were protected by a lock, but the out-vq operations were not. This caused panics / errors as described in patch 2. Fix that.

The first patch renames the existing cvq_lock to c_ivq_lock to match c_ivq. The second patch introduces the c_ovq_lock for the c_ovq.

Please apply. I also believe this is a candidate for stable.

v2:
* Use spin_lock instead of spin_lock_irq. Pointed out by Wanlong Gao.

Amit Shah (2):
virtio: console: rename cvq_lock to c_ivq_lock
virtio: console: add locking around c_ovq operations

 drivers/char/virtio_console.c | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)
Signature · 1 line
1.8.1.4