Nokia N9 specific quirks
Get series with b4
b4 am [email protected]Versions newest first
- v4 Latest8 patches 2 repliesIn review
Changes in v4 from the cover letter
* Retry CLCC request on outgoing callsetup is now a N9 specific quirk
* Third patch has been split up according to HACKING rules
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | hfpmodem: Add modem vendor stubdrivers/ | +25 | 0 replies | |
| 2/8 | hfpmodem: Add vendor header to makefileMakefile.am | +2 | 0 replies | |
| 3/8 | hfpmodem: Add vendor information to voicecall datadrivers/ | +3 | 0 replies | |
| 4/8 | hfp_hf_bluez4: Pass vendor on voicecall creationplugins/ | +3 | 0 replies | |
| 5/8 | hfp_hf_bluez5: Pass vendor on voicecall creationplugins/ | +4 | 0 replies | |
| 6/8 | hfpmodem: Add method to query if CLCC quirks are neededdrivers/ drivers/ | +14 | 0 replies | |
| 7/8 | hfpmodem: Add N9 quirk for outgoing callsetupdrivers/ | +45 | 0 replies | |
| 8/8 | hfpmodem: Add N9 quirk for callheld=<2 or 3>drivers/ | +12 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [PATCHv4 0/8] Nokia N9 specific quirks
From: Timo Mueller <[email protected]>
Hi,
this is the same as v3 with the changes suggested by Denis.
v4 changes:
* Retry CLCC request on outgoing callsetup is now a N9 specific quirk
* Third patch has been split up according to HACKING rules
The idea of setting the vendor during runtime was to use the "Model" string of the ofono_modem (analogous to what the wavecom modem does). But as the Nokia N9 does not support the device ID profile and the BT address has an OUI from Texas Instruments, I wasn't able to determine that the hfpmodem is a Nokia N9. Maybe you have some ideas on how this can be determined properly?
As currently there's no functionality to detect the vendor of a hfpmodem on runtime the clcc quirk can be enabled for all vendors by patching the needs_callheld_clcc_quirk method.
Regards,
Timo
Timo Mueller (8):
hfpmodem: Add modem vendor stub
hfpmodem: Add vendor header to makefile
hfpmodem: Add vendor information to voicecall data
hfp_hf_bluez4: Pass vendor on voicecall creation
hfp_hf_bluez5: Pass vendor on voicecall creation
hfpmodem: Add method to query if CLCC quirks are needed
hfpmodem: Add N9 quirk for outgoing callsetup
hfpmodem: Add N9 quirk for callheld=<2 or 3>
Makefile.am | 3 +- drivers/hfpmodem/vendor.h | 26 +++++++++++++++ drivers/hfpmodem/voicecall.c | 77 +++++++++++++++++++++++++++++++++++++++++--- plugins/hfp_hf_bluez4.c | 4 ++- plugins/hfp_hf_bluez5.c | 5 ++- 5 files changed, 107 insertions(+), 8 deletions(-) create mode 100644 drivers/hfpmodem/vendor.h
Signature · 1 line
1.7.11.7