Skip to content

Nokia N9 specific quirks

Timo Mueller ofono 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest8 patches 2 repliesIn review

Changes in v4 from the cover letter

* Retry CLCC request on outgoing callsetup is now a N9 specific quirk
* Third patch has been split up according to HACKING rules

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8hfpmodem: Add modem vendor stubdrivers/hfpmodem/vendor.h+25 -00 replies
2/8hfpmodem: Add vendor header to makefileMakefile.am+2 -10 replies
3/8hfpmodem: Add vendor information to voicecall datadrivers/hfpmodem/voicecall.c+3 -00 replies
4/8hfp_hf_bluez4: Pass vendor on voicecall creationplugins/hfp_hf_bluez4.c+3 -10 replies
5/8hfp_hf_bluez5: Pass vendor on voicecall creationplugins/hfp_hf_bluez5.c+4 -10 replies
6/8hfpmodem: Add method to query if CLCC quirks are neededdrivers/hfpmodem/vendor.h drivers/hfpmodem/voicecall.c+14 -10 replies
7/8hfpmodem: Add N9 quirk for outgoing callsetupdrivers/hfpmodem/voicecall.c+45 -50 replies
8/8hfpmodem: Add N9 quirk for callheld=<2 or 3>drivers/hfpmodem/voicecall.c+12 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCHv4 0/8] Nokia N9 specific quirks

From: Timo Mueller <[email protected]>

Hi,

this is the same as v3 with the changes suggested by Denis.

v4 changes:
* Retry CLCC request on outgoing callsetup is now a N9 specific quirk
* Third patch has been split up according to HACKING rules

The idea of setting the vendor during runtime was to use the "Model" string of the ofono_modem (analogous to what the wavecom modem does). But as the Nokia N9 does not support the device ID profile and the BT address has an OUI from Texas Instruments, I wasn't able to determine that the hfpmodem is a Nokia N9. Maybe you have some ideas on how this can be determined properly?

As currently there's no functionality to detect the vendor of a hfpmodem on runtime the clcc quirk can be enabled for all vendors by patching the needs_callheld_clcc_quirk method.

Regards,
Timo

Timo Mueller (8):
hfpmodem: Add modem vendor stub
hfpmodem: Add vendor header to makefile
hfpmodem: Add vendor information to voicecall data
hfp_hf_bluez4: Pass vendor on voicecall creation
hfp_hf_bluez5: Pass vendor on voicecall creation
hfpmodem: Add method to query if CLCC quirks are needed
hfpmodem: Add N9 quirk for outgoing callsetup
hfpmodem: Add N9 quirk for callheld=<2 or 3>

 Makefile.am                  |  3 +-
 drivers/hfpmodem/vendor.h    | 26 +++++++++++++++
 drivers/hfpmodem/voicecall.c | 77 +++++++++++++++++++++++++++++++++++++++++---
 plugins/hfp_hf_bluez4.c      |  4 ++-
 plugins/hfp_hf_bluez5.c      |  5 ++-
 5 files changed, 107 insertions(+), 8 deletions(-)
 create mode 100644 drivers/hfpmodem/vendor.h
Signature · 1 line
1.7.11.7