Skip to content

Xilinx SPIPS fixes round 2

[email protected] qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest15 patches 1 replyIn review
  2. v315 patches 4 repliesSuperseded
  3. v215 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v115 patches16 repliesSuperseded

Changes in v4 from the cover letter

Fixed break after goto (PMM review)

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15xilinx_spips: seperate SPI and QSPI as two classeshw/arm/xilinx_zynq.c hw/ssi/xilinx_spips.c+56 -150 replies
2/15xilinx_spips: Make interrupts clear on readhw/ssi/xilinx_spips.c+4 -00 replies
3/15xilinx_spips: Inhibit interrupts in LQSPI modehw/ssi/xilinx_spips.c+6 -10 replies
4/15xilinx_spips: Add verbose LQSPI debug outputhw/ssi/xilinx_spips.c+4 -10 replies
5/15xilinx_spips: Fix QSPI FIFO sizehw/ssi/xilinx_spips.c+25 -20 replies
6/15xilinx_spips: Trash LQ page cache on mode changehw/ssi/xilinx_spips.c+24 -10 replies
7/15xilinx_spips: Add automatic start supporthw/ssi/xilinx_spips.c+2 -10 replies
8/15xilinx_spips: Implement automatic CShw/ssi/xilinx_spips.c+14 -40 replies
9/15xilinx_spips: lqspi: Dont touch config registerhw/ssi/xilinx_spips.c+6 -60 replies
10/15xilinx_spips: Fix CTRL register RW bitshw/ssi/xilinx_spips.c+3 -20 replies
11/15xilinx_spips: Fix striping behaviourhw/ssi/xilinx_spips.c+63 -210 replies
12/15xilinx_spips: Debug msgs for Snoop statehw/ssi/xilinx_spips.c+3 -00 replies
13/15xilinx_spips: Multiple debug verbosity levelshw/ssi/xilinx_spips.c+42 -280 replies
14/15xilinx_spips: lqspi: Push more data to tx-fifohw/ssi/xilinx_spips.c+7 -40 replies
15/15xilinx_spips: lqspi: Fix byte/misaligned accesshw/ssi/xilinx_spips.c+17 -140 replies

Reviews trailers per patch

All 15 patches have a Reviewed-by or Acked-by.

PatchPeter MaydellEdgar E. Iglesias
1/15R-b R-b
2/15R-b R-b
3/15R-b R-b
4/15R-b R-b
5/15R-b R-b
6/15R-b R-b
7/15R-b R-b
8/15R-b R-b
9/15R-b R-b
10/15R-b R-b
11/15R-b R-b
12/15R-b R-b
13/15R-b R-b
14/15R-b R-b
15/15R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH arm-devs v4 00/15] Xilinx SPIPS fixes round 2

From: Peter Crosthwaite <[email protected]>

Updates to the Zynq SPI controller. Some QOMifying cleanup, followed by a number of bugs/incompletnesses found by some (very) rigourous test vectors.

changed from v4:
Address PMM review (P5 and P8)
changed from v3:
Fixed break after goto (PMM review)

Peter Crosthwaite (15):
xilinx_spips: seperate SPI and QSPI as two classes
xilinx_spips: Make interrupts clear on read
xilinx_spips: Inhibit interrupts in LQSPI mode
xilinx_spips: Add verbose LQSPI debug output
xilinx_spips: Fix QSPI FIFO size
xilinx_spips: Trash LQ page cache on mode change
xilinx_spips: Add automatic start support
xilinx_spips: Implement automatic CS
xilinx_spips: lqspi: Dont touch config register
xilinx_spips: Fix CTRL register RW bits
xilinx_spips: Fix striping behaviour
xilinx_spips: Debug msgs for Snoop state
xilinx_spips: Multiple debug verbosity levels
xilinx_spips: lqspi: Push more data to tx-fifo
xilinx_spips: lqspi: Fix byte/misaligned access

 hw/arm/xilinx_zynq.c  |   2 +-
 hw/ssi/xilinx_spips.c | 320 ++++++++++++++++++++++++++++++++++++++------------
 2 files changed, 249 insertions(+), 73 deletions(-)
Signature · 1 line
1.8.3.rc1.44.gb387c77.dirty