Skip to content

Pull request 20130408

Apelete Seketeli openembedded-devel 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest1 patch 0 repliesNew
  2. v21 patch 0 repliesSuperseded
  3. v12 patches 1 replySuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1linux-jlime-ben-nanonote: fix GCC-4.6 build errorsrecipes-kernel/linux/linux-jlime-ben-nanonote-2.6.36/fix-gcc-4.6.0-build-errors.patch recipes-kernel/linux/linux-jlime-ben-nanonote_2.6.36.bb+128 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [meta-handheld][PATCH v3 0/1] Pull request 20130408

Hello,

Quoted 16 lines · Apelete Seketeli
Quoted 12 lines · Apelete Seketeli

Following the patches I sent to the meta-handheld layer a few days ago to add machine support for the Ben Nanonote, I found out that the corresponding kernel recipe fails to build on oe-core (builds fine on oe-classic).
A few settings were missing and, more importantly, the version of gcc in oe-core seems to enable the -Wunused-but-set-variable switch, which makes it error on many variables that were indeed 'unused but set'. After trying to solve this issue the easy way, by setting 'CFLAGS=-Wno-error=unused-but-set-variable -Wno-error=unused-but-set-parameter' to no avail, I chose to annotate the aforementioned variables in the kernel code with __attribute__((__unused__)).

Quoted 2 lines

The patches that come as a follow-up of this message are what it's all about; sorry for the inconvenience in the first place.

Quoted 8 lines

I took the time to fix the patch for the GCC 4.6 build issue. Instead of just fixing the issue on my own, I looked at how it was done in the mainline kernel and backported the fixes through a new patch named fix-gcc-4.6.0-build-errors.patch; this approach seems more logical to me.
While I was at it, also removed "[PATCH 2/2] ben-nanonote: add DEFAULTTUNE to machine configuration" from the patchset, following Paul's advice.

Added a header to the "fix-gcc-4.6.0-build-errors.patch" kernel patch, describing the changes and stating the Upstream-Status.

Tested by building linux-jlime-ben-nanonote from scratch on top of master branch.
Please pull into meta-handheld.

The following changes since commit 913735dce388f660dfbbe288ed736e12ed48c8d8:

linux-yocto-tiny-kexecboot_3.2: removed unused, non-working MTD-RW patch (2013-04-06 00:25:08 +0100)

are available in the git repository at:

git://seketeli.fr/~apelete/meta-handheld.git fix-nn-kernel-build

Apelete Seketeli (1):
linux-jlime-ben-nanonote: fix GCC-4.6 build errors

 .../fix-gcc-4.6.0-build-errors.patch               |  124 ++++++++++++++++++++
 .../linux/linux-jlime-ben-nanonote_2.6.36.bb       |    5 +-
 2 files changed, 128 insertions(+), 1 deletion(-)
 create mode 100644 recipes-kernel/linux/linux-jlime-ben-nanonote-2.6.36/fix-gcc-4.6.0-build-errors.patch
Signature · 1 line
1.7.10.4