submodule: drop the top-level requirement
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest6 patches 1 replyIn review
- v32 patches 11 repliesSuperseded
- v22 patches 9 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 2 patches | 6 replies | Superseded |
Changes in v4 from the cover letter
* There are four new patches, three of which are style fixes for existing tests and one fixes an existing error message to return a more accurate path when recursing.
* You now cannot run "git submodule add <relative URL>" from a subdirectory. Because the interpretation of the URL changes depending on whether or not remote.origin.url is configured, I have decided to just ban this for now. If someone comes up with a sensible way to handle this then we can lift this restriction later.
* The "path" variable exported in "submodule foreach" now uses the relative path and matches the "sm_path" variable.
* I audited the code again and fixed a few more cases that weren't printing relative paths (notably "submodule init" and "submodule foreach").
* More tests.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | t7401: make indentation consistentt/ | +40 | 0 replies | |
| 2/6 | t7403: modernize stylet/ | +183 | 0 replies | |
| 3/6 | t7403: add missing && chainingt/ | +2 | 0 replies | |
| 4/6 | submodule: show full path in error messagegit-submodule.sh | +1 | 0 replies | |
| 5/6 | rev-parse: add --prefix optionDocumentation/ builtin/ t/ | +131 | 0 replies | |
| 6/6 | submodule: drop the top-level requirementgit-submodule.sh t/ t/ +3 more | +319 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [PATCH v4 0/6] submodule: drop the top-level requirement
Changes since v3:
* There are four new patches, three of which are style fixes for existing tests and one fixes an existing error message to return a more accurate path when recursing.
* You now cannot run "git submodule add <relative URL>" from a subdirectory. Because the interpretation of the URL changes depending on whether or not remote.origin.url is configured, I have decided to just ban this for now. If someone comes up with a sensible way to handle this then we can lift this restriction later.
* The "path" variable exported in "submodule foreach" now uses the relative path and matches the "sm_path" variable.
* I audited the code again and fixed a few more cases that weren't printing relative paths (notably "submodule init" and "submodule foreach").
* More tests.
John Keeping (6):
t7401: make indentation consistent
t7403: modernize style
t7403: add missing && chaining
submodule: show full path in error message
rev-parse: add --prefix option
submodule: drop the top-level requirement
Documentation/git-rev-parse.txt | 16 ++ builtin/rev-parse.c | 24 ++- git-submodule.sh | 135 ++++++++++---- t/t1513-rev-parse-prefix.sh | 96 ++++++++++ t/t7400-submodule-basic.sh | 80 +++++++++ t/t7401-submodule-summary.sh | 116 +++++++----- t/t7403-submodule-sync.sh | 388 ++++++++++++++++++++++++++-------------- t/t7406-submodule-update.sh | 15 ++ t/t7407-submodule-foreach.sh | 16 ++ 9 files changed, 673 insertions(+), 213 deletions(-) create mode 100755 t/t1513-rev-parse-prefix.sh
Signature · 1 line
1.8.3.779.g691e267