Handle signed tags with 'export' remote helpers
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | fast-export: add --signed-tags=warn-strip modeDocumentation/ builtin/ t/ | +19 | 7 replies | |
| 2/3 | transport-helper: pass --signed-tags=warn-strip to fast-exportt/ transport-helper.c | +12 | 0 replies | |
| 3/3 | transport-helper: add 'signed-tags' capabilityDocumentation/ git-remote-testgit t/ +1 more | +21 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] Handle signed tags with 'export' remote helpers
Quoted 11 lines · Sverre Rabbelier
Quoted 5 lines · Jonathan Nieder
The remote helper infrastructure is certainly being unhelpful here. I wonder if transport-helper should just pass --signed-tag=strip and be done with it (leaving open the possibility of a capability to switch to --signed-tag=verbatim when someone wants to teach the testgit helper to support that). What do you think?
I think that's (at least for now) the right thing to do. Passing anything but signed-tag=strip should be triggered by a capability from the helper, since most helpers won't know how to deal with signed tags.
I don't like the idea of silently stripping tags, so how about this?
Patch 1 adds a new 'warn-strip' mode to 'fast-export --signed-tags=...' which strips tags but issues a warning when doing so. Then we make transport-helper use that before finally adding a new capability to allow a remote helper to change '--signed-tags=warn-strip' into '--signed-tags=verbatim'.
John Keeping (3):
fast-export: add --signed-tags=warn-strip mode
transport-helper: pass --signed-tags=warn-strip to fast-export
transport-helper: add 'signed-tags' capability
Documentation/git-fast-export.txt | 10 ++++++---- Documentation/gitremote-helpers.txt | 4 ++++ builtin/fast-export.c | 8 +++++++- git-remote-testgit | 1 + t/t5801-remote-helpers.sh | 20 ++++++++++++++++++++ t/t9350-fast-export.sh | 6 ++++++ transport-helper.c | 7 ++++++- 7 files changed, 50 insertions(+), 6 deletions(-)
Signature · 1 line
1.8.2.694.ga76e9c3.dirty