Skip to content

opregion asle enable cleanups

Jani Nikula intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/i915: cleanup opregion technology enabled indicator definesdrivers/gpu/drm/i915/intel_opregion.c+7 -61 reply
2/6drm/i915: manage opregion asle driver readiness properlydrivers/gpu/drm/i915/intel_opregion.c+14 -41 reply
3/6drm/i915: untie opregion init and asle irq/pipestat enabledrivers/gpu/drm/i915/intel_opregion.c+0 -23 replies
4/6drm/i915: cleanup redundant checks from intel_enable_asledrivers/gpu/drm/i915/i915_irq.c+3 -131 reply
5/6drm/i915: cleanup opregion asle pipestat enabledrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/intel_opregion.c+7 -191 reply
6/6drm/i915: drop locking from asle pipestat enabledrivers/gpu/drm/i915/i915_irq.c+3 -93 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchDamien Lespiau
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] opregion asle enable cleanups

This series is a stab at untangling some of the opregion code, particularly related to opregion asle enable. The only "real" change should be clearing the driver readiness status in patch 2; otherwise it *should* be just non-functional cleanup. I've split this up into perhaps more patches than would be strictly necessary, but it should be helpful in case there are subtle changes in bios/driver interaction that need to be bisected.

This should complete the cleanups outlined by Daniel [1].

Cheers,
Jani.

[1] http://thread.gmane.org/gmane.comp.freedesktop.xorg.drivers.intel/19270/focus=19437

Jani Nikula (6):
drm/i915: cleanup opregion technology enabled indicator defines drm/i915: manage opregion asle driver readiness properly drm/i915: untie opregion init and asle irq/pipestat enable drm/i915: cleanup redundant checks from intel_enable_asle drm/i915: cleanup opregion asle pipestat enable drm/i915: drop locking from asle pipestat enable

 drivers/gpu/drm/i915/i915_drv.h       |    4 ----
 drivers/gpu/drm/i915/i915_irq.c       |   31 ++++++++-----------------
 drivers/gpu/drm/i915/intel_opregion.c |   40 ++++++++++++++++-----------------
 3 files changed, 28 insertions(+), 47 deletions(-)
Signature · 1 line
1.7.9.5