Skip to content

drm/i915: sideband refactoring

Jani Nikula intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 6 repliesIn review
  2. v1 RFC3 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/i915: group sideband register accessors to a new filedrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c +3 more+192 -1621 reply
2/5drm/i915: refactor VLV IOSF sideband accessors to use one helperdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_sideband.c+93 -1021 reply
3/5drm/i915: drop redundant warnings on not holding dpio_lockdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_hdmi.c+0 -101 reply
4/5drm/i915: rename VLV IOSF sideband functions logicallydrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_sysfs.c +5 more+91 -911 reply
5/5drm/i915: change VLV IOSF sideband accessors to not return error codedrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_sysfs.c +2 more+27 -362 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJesse Barnes
1/5R-b
2/5A-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] drm/i915: sideband refactoring

Hi all, v2 of the vlv (and now partially also hsw) sideband refactoring patches [1], addressing Daniel's comments and with two new patches cleaning things up a bit.

BR,
Jani.

[1] http://mid.gmane.org/[email protected]

Jani Nikula (5):
drm/i915: group sideband register accessors to a new file drm/i915: refactor VLV IOSF sideband accessors to use one helper drm/i915: drop redundant warnings on not holding dpio_lock drm/i915: rename VLV IOSF sideband functions logically drm/i915: change VLV IOSF sideband accessors to not return error code

 drivers/gpu/drm/i915/Makefile         |    1 +
 drivers/gpu/drm/i915/i915_debugfs.c   |   25 +++--
 drivers/gpu/drm/i915/i915_drv.h       |   14 ++-
 drivers/gpu/drm/i915/i915_reg.h       |   93 ++++++++---------
 drivers/gpu/drm/i915/i915_sysfs.c     |    2 +-
 drivers/gpu/drm/i915/intel_display.c  |  144 +++++----------------------
 drivers/gpu/drm/i915/intel_dp.c       |   38 +++----
 drivers/gpu/drm/i915/intel_drv.h      |    4 -
 drivers/gpu/drm/i915/intel_hdmi.c     |   46 ++++-----
 drivers/gpu/drm/i915/intel_pm.c       |   80 ++-------------
 drivers/gpu/drm/i915/intel_sideband.c |  177 +++++++++++++++++++++++++++++++++
 11 files changed, 313 insertions(+), 311 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/intel_sideband.c
Signature · 1 line
1.7.10.4