Skip to content

disable the scsi pass-through eject from monitor

Pavel Hrdina qemu-devel 1 version Applied

Status from this message: Applied to scsi branch with the BADF removed. Thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2scsi-generic: check the return value of bdrv_aio_ioctl in execute_commandhw/scsi/scsi-generic.c+4 -01 reply
2/2scsi-disk: scsi-block device for scsi pass-through should not be removablehw/scsi/scsi-disk.c+7 -35 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/2] disable the scsi pass-through eject from monitor

This series do two things, at first it fixes the bug introduced by Paolo's patch series. The bug is that he accidentally removes the check after the bdrv_aio_ioctl() function which still could return NULL.

The second patch fixes the issue that you could eject the scsi pass-through device from the guest. Probably it should be later fixed in the way that the eject command will not remove the device from guest, but send the eject request to the real device in case of removable device.

Pavel Hrdina (2):
scsi-generic: check the return value of bdrv_aio_ioctl in
execute_command
scsi-disk: scsi-block device for scsi pass-through should not be
removable

 hw/scsi/scsi-disk.c    | 10 +++++++---
 hw/scsi/scsi-generic.c |  4 ++++
 2 files changed, 11 insertions(+), 3 deletions(-)
Signature · 1 line
1.8.1.4