Skip to content

pktcdvd: More neatenings

Joe Perches kernel-janitors lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 2 repliesIn review
  2. v28 patches 7 repliesSuperseded
  3. v13 patches 3 repliesSuperseded

Changes in v3 from the cover letter

Fixed patch 2 thinko in sense_string via Dan Carpenter
Moved pr_err in patch 5 to avoid moving again in patch 6 via Andy Schevchenko

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8pktcdvd: Convert ZONE macro to static function get_zone()drivers/block/pktcdvd.c+10 -100 replies
2/8pktcdvd: Convert printk to pr_<level>drivers/block/pktcdvd.c+61 -610 replies
3/8pktcdvd: Consolidate DPRINTK and VPRINTK macrosdrivers/block/pktcdvd.c+53 -540 replies
4/8pktcdvd: Add struct pktcdvd_device * to pkt_dbgdrivers/block/pktcdvd.c+42 -480 replies
5/8pktcdvd: Add struct pktcdvd_device.name to pr_err logging where possibledrivers/block/pktcdvd.c+24 -200 replies
6/8pktcdvd: Convert pr_notice to pkt_noticedrivers/block/pktcdvd.c+12 -100 replies
7/8pktcdvd: Convert pr_info to pkt_infodrivers/block/pktcdvd.c+8 -60 replies
8/8pktcdvd: Add struct pktcdvd_device * to pkt_dump_sense()drivers/block/pktcdvd.c+16 -150 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by.

PatchAndy ShevchenkoDan Carpenter
1/8
2/8Improved-by Improved-by
3/8
4/8
5/8Improved-by
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH V3 0/8] pktcdvd: More neatenings

Thanks for the oversight reviews guys.

V3:
Fixed patch 2 thinko in sense_string via Dan Carpenter
Moved pr_err in patch 5 to avoid moving again in patch 6 via Andy Schevchenko

V2:
Removed the compile error the patch 1 and compile fix in 2 Added Andy's suggestion in patch 2.
Added conversions to print pd->name in logging macros.

Joe Perches (8):
pktcdvd: Convert ZONE macro to static function get_zone()
pktcdvd: Convert printk to pr_<level>
pktcdvd: Consolidate DPRINTK and VPRINTK macros
pktcdvd: Add struct pktcdvd_device * to pkt_dbg
pktcdvd: Add struct pktcdvd_device.name to pr_err logging where possible
pktcdvd: Convert pr_notice to pkt_notice
pktcdvd: Convert pr_info to pkt_info
pktcdvd: Add struct pktcdvd_device * to pkt_dump_sense()

 drivers/block/pktcdvd.c | 278 ++++++++++++++++++++++++------------------------
 1 file changed, 140 insertions(+), 138 deletions(-)
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty