Skip to content

Increase test coverage on Windows by removing SYMLINKS from many tests

Johannes Sixt git 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 2 repliesIn review
  2. v111 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- Ripped out test_ln_s and corresponding conversions; they were dubious.

- There are no changes to t2100 anymore; the corresponding modernization patch is gone.

- Moved the t4011 change from the "trivial cases" to its own patch. It still contains the effects of the former test_ln_s, but open-coded and with a comment.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10test-chmtime: Fix exit code on Windowstest-chmtime.c+4 -41 reply
2/10t3010: modernize stylet/t3010-ls-files-killed-modified.sh+61 -620 replies
3/10tests: introduce test_ln_s_addt/README t/test-lib-functions.sh+31 -00 replies
4/10tests: use test_ln_s_add to remove SYMLINKS prerequisite (trivial cases)t/t1004-read-tree-m-u-wf.sh t/t2001-checkout-cache-clash.sh t/t2004-checkout-cache-temp.sh +16 more+106 -1100 replies
5/10t0000: use test_ln_s_add to remove SYMLINKS prerequisitet/t0000-basic.sh+10 -290 replies
6/10t3030: use test_ln_s_add to remove SYMLINKS prerequisitet/t3030-merge-recursive.sh+26 -360 replies
7/10t3100: use test_ln_s_add to remove SYMLINKS prerequisitet/t3100-ls-tree-restrict.sh+15 -270 replies
8/10t3509, t4023, t4114: use test_ln_s_add to remove SYMLINKS prerequisitet/t3509-cherry-pick-merge-df.sh t/t4023-diff-rename-typechange.sh t/t4114-apply-typechange.sh+33 -360 replies
9/10t6035: use test_ln_s_add to remove SYMLINKS prerequisitet/t6035-merge-dir-to-symlink.sh+47 -260 replies
10/10t4011: remove SYMLINKS prerequisitet/t4011-diff-symlink.sh+25 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/10] Increase test coverage on Windows by removing SYMLINKS from many tests

Many tests that involve symbolic links actually check only whether our algorithms are correct by investigating the contents of the object database and the index. Only some of them check the filesystem.

This series introduces a function test_ln_s_add that inserts a symbolic link in the index even if the filesystem does not support symbolic links. By using this function, many more tests can be run when the filesystem does not have symblic links, aka Windows.

Changes since v1:

- Ripped out test_ln_s and corresponding conversions; they were dubious.

- There are no changes to t2100 anymore; the corresponding modernization patch is gone.

- Moved the t4011 change from the "trivial cases" to its own patch. It still contains the effects of the former test_ln_s, but open-coded and with a comment.

Johannes Sixt (10):
test-chmtime: Fix exit code on Windows
t3010: modernize style
tests: introduce test_ln_s_add
tests: use test_ln_s_add to remove SYMLINKS prerequisite (trivial
cases)
t0000: use test_ln_s_add to remove SYMLINKS prerequisite
t3030: use test_ln_s_add to remove SYMLINKS prerequisite
t3100: use test_ln_s_add to remove SYMLINKS prerequisite t3509, t4023, t4114: use test_ln_s_add to remove SYMLINKS prerequisite
t6035: use test_ln_s_add to remove SYMLINKS prerequisite
t4011: remove SYMLINKS prerequisite

 t/README                               |  14 ++++
 t/t0000-basic.sh                       |  39 +++--------
 t/t1004-read-tree-m-u-wf.sh            |   7 +-
 t/t2001-checkout-cache-clash.sh        |   7 +-
 t/t2004-checkout-cache-temp.sh         |   5 +-
 t/t2007-checkout-symlink.sh            |  12 ++--
 t/t2021-checkout-overwrite.sh          |  12 ++--
 t/t2200-add-update.sh                  |   5 +-
 t/t3010-ls-files-killed-modified.sh    | 118 ++++++++++++++++-----------------
 t/t3030-merge-recursive.sh             |  62 ++++++++---------
 t/t3100-ls-tree-restrict.sh            |  42 +++++-------
 t/t3509-cherry-pick-merge-df.sh        |  12 ++--
 t/t3700-add.sh                         |  15 ++---
 t/t3903-stash.sh                       |  39 ++++++++---
 t/t4008-diff-break-rewrite.sh          |  12 ++--
 t/t4011-diff-symlink.sh                |  35 +++++++---
 t/t4023-diff-rename-typechange.sh      |  28 ++++----
 t/t4030-diff-textconv.sh               |   8 +--
 t/t4114-apply-typechange.sh            |  29 ++++----
 t/t4115-apply-symlink.sh               |  10 ++-
 t/t4122-apply-symlink-inside.sh        |   8 +--
 t/t6035-merge-dir-to-symlink.sh        |  73 ++++++++++++--------
 t/t7001-mv.sh                          |  18 +++--
 t/t7607-merge-overwrite.sh             |   5 +-
 t/t8006-blame-textconv.sh              |  14 ++--
 t/t8007-cat-file-textconv.sh           |  10 ++-
 t/t9350-fast-export.sh                 |   5 +-
 t/t9500-gitweb-standalone-no-errors.sh |  15 ++---
 t/test-lib-functions.sh                |  17 +++++
 test-chmtime.c                         |   8 +--
 30 files changed, 351 insertions(+), 333 deletions(-)
Signature · 1 line
1.8.3.rc1.32.g8b61cbb