PCI: Cleanup legacy casts in device land
Status from this message: Thanks, applied to qom-next:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest30 patches 21 repliesApplied
- v130 patches 6 repliesSuperseded
Changes in v2 from the cover letter
Removed hunks which macroified VMSD names
Dropped virtio/virtio.pci patch
Rebased
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/30 | net/e1000: QOM Upcast Sweephw/ | +12 | 1 reply | |
| 2/30 | net/rtl8139: QOM Upcast Sweephw/ | +18 | 1 reply | |
| 3/30 | net/pcnet-pci: QOM Upcast Sweephw/ | +9 | 3 replies | |
| 4/30 | usb/hcd-xhci: QOM Upcast Sweephw/ | +13 | 2 replies | |
| 5/30 | scsi/lsi53c895a: QOM Upcast Sweephw/ | +16 | 2 replies | |
| 6/30 | scsi/megasas: QOM Upcast Sweephw/ | +10 | 1 reply | |
| 7/30 | scsi/esp-pci: QOM Upcast Sweephw/ | +9 | 1 reply | |
| 8/30 | ide/ich: QOM Upcast Sweephw/ hw/ | +10 | 5 replies | |
| 9/30 | ide/piix: QOM casting sweephw/ | +4 | 4 replies | |
| 10/30 | acpi/piix4: QOM Upcast Sweephw/ | +17 | 1 reply | |
| 11/30 | misc/pci-testdev: QOM Upcast Sweephw/ | +8 | 2 replies | |
| 12/30 | virtio/vmware_vga: QOM casting sweephw/ | +8 | 2 replies | |
| 13/30 | misc/ivshmem: QOM Upcast Sweephw/ | +11 | 3 replies | |
| 14/30 | xen/xen_platform: QOM casting sweephw/ | +16 | 2 replies | |
| 15/30 | isa/*: QOM casting sweephw/ hw/ | +7 | 0 replies | |
| 16/30 | pci/*: QOM casting sweephw/ hw/ hw/ +1 more | +25 | 1 reply | |
| 17/30 | pci-bridge/pci_bridge_dev: Don't use DO_UPCASThw/ | +1 | 0 replies | |
| 18/30 | pci-bridge/*: substitute ->qdev casts with DEVICE()hw/ hw/ hw/ +1 more | +4 | 0 replies | |
| 19/30 | pci/pci_bridge: substitute ->qdev casts with DEVICE()hw/ | +4 | 0 replies | |
| 20/30 | misc/vfio: substitute ->qdev casts with DEVICE()hw/ | +2 | 0 replies | |
| 21/30 | net/eepro100: substitute ->qdev casts with DEVICE()hw/ | +8 | 0 replies | |
| 22/30 | net/ne2000: substitute ->qdev casts with DEVICE()hw/ | +4 | 0 replies | |
| 23/30 | usb/*: substitute ->qdev casts with DEVICE()hw/ hw/ hw/ | +10 | 0 replies | |
| 24/30 | watchdog/wdt_i6300esb: substitute ->qdev casts with DEVICE()hw/ | +1 | 0 replies | |
| 25/30 | scsi/vmw_pvscsi: substitute ->qdev casts with DEVICE()hw/ | +1 | 0 replies | |
| 26/30 | i2c/smbus_ich9: substitute ->qdev casts with DEVICE()hw/ | +1 | 0 replies | |
| 27/30 | ide/cmd646: substitute ->qdev casts with DEVICE()hw/ | +4 | 0 replies | |
| 28/30 | ide/via: substitute ->qdev casts with DEVICE()hw/ | +2 | 0 replies | |
| 29/30 | pci-host/*: substitute ->qdev casts with DEVICE()hw/ hw/ hw/ | +5 | 0 replies | |
| 30/30 | i386/*: substitute ->qdev casts with DEVICE()hw/ hw/ hw/ +1 more | +18 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [Qemu-devel] [PATCH v2 00/30] PCI: Cleanup legacy casts in device land
From: Peter Crosthwaite <[email protected]>
There are a number of different cast implementations from various stages of QEMU development out in device model land. This series cleans up the ones involving TYPE_PCI_DEVICE to consistently use proper QOM casts for both up and down casts.
Some were easy, some needed QOM cast macros which are added as appropriate.
Following the recent discussion RE performance consequences of QOM casts, im interested in any reports of possible performance regressions here, although I am hoping that Anthony current efforts to improve QOM casting efficiency make this a non-issue.
Changed since V1:
Removed hunks which macroified VMSD names
Dropped virtio/virtio.pci patch
Rebased
Peter Crosthwaite (30):
net/e1000: QOM Upcast Sweep
net/rtl8139: QOM Upcast Sweep
net/pcnet-pci: QOM Upcast Sweep
usb/hcd-xhci: QOM Upcast Sweep
scsi/lsi53c895a: QOM Upcast Sweep
scsi/megasas: QOM Upcast Sweep
scsi/esp-pci: QOM Upcast Sweep
ide/ich: QOM Upcast Sweep
ide/piix: QOM casting sweep
acpi/piix4: QOM Upcast Sweep
misc/pci-testdev: QOM Upcast Sweep virtio/vmware_vga: QOM casting sweep
misc/ivshmem: QOM Upcast Sweep
xen/xen_platform: QOM casting sweep
isa/*: QOM casting sweep
pci/*: QOM casting sweep pci-bridge/pci_bridge_dev: Don't use DO_UPCAST pci-bridge/*: substitute ->qdev casts with DEVICE() pci/pci_bridge: substitute ->qdev casts with DEVICE() misc/vfio: substitute ->qdev casts with DEVICE() net/eepro100: substitute ->qdev casts with DEVICE() net/ne2000: substitute ->qdev casts with DEVICE() usb/*: substitute ->qdev casts with DEVICE() watchdog/wdt_i6300esb: substitute ->qdev casts with DEVICE() scsi/vmw_pvscsi: substitute ->qdev casts with DEVICE() i2c/smbus_ich9: substitute ->qdev casts with DEVICE() ide/cmd646: substitute ->qdev casts with DEVICE() ide/via: substitute ->qdev casts with DEVICE() pci-host/*: substitute ->qdev casts with DEVICE() i386/*: substitute ->qdev casts with DEVICE()
hw/acpi/piix4.c | 31 +++++++++++++++++-------------- hw/display/vmware_vga.c | 13 ++++++++----- hw/i2c/smbus_ich9.c | 2 +- hw/i386/kvm/pci-assign.c | 21 ++++++++++++--------- hw/i386/pc.c | 3 ++- hw/i386/pc_piix.c | 4 ++-- hw/i386/pc_q35.c | 4 ++-- hw/ide/ahci.h | 5 +++++ hw/ide/cmd646.c | 8 ++++---- hw/ide/ich.c | 10 +++++----- hw/ide/piix.c | 8 ++++---- hw/ide/via.c | 4 ++-- hw/isa/i82378.c | 8 ++++---- hw/isa/lpc_ich9.c | 6 +++--- hw/misc/ivshmem.c | 18 +++++++++++------- hw/misc/pci-testdev.c | 11 ++++++++--- hw/misc/vfio.c | 4 ++-- hw/net/e1000.c | 18 ++++++++++++------ hw/net/eepro100.c | 14 ++++++++------ hw/net/ne2000.c | 6 ++++-- hw/net/pcnet-pci.c | 14 +++++++++----- hw/net/rtl8139.c | 26 ++++++++++++++++++-------- hw/pci-bridge/dec.c | 2 +- hw/pci-bridge/i82801b11.c | 2 +- hw/pci-bridge/ioh3420.c | 2 +- hw/pci-bridge/pci_bridge_dev.c | 2 +- hw/pci-bridge/xio3130_downstream.c | 2 +- hw/pci-bridge/xio3130_upstream.c | 2 +- hw/pci-host/apb.c | 4 ++-- hw/pci-host/q35.c | 4 ++-- hw/pci/pci-hotplug.c | 18 ++++++++++-------- hw/pci/pci.c | 17 +++++++++-------- hw/pci/pci_bridge.c | 7 ++++--- hw/pci/pcie.c | 4 ++-- hw/pci/shpc.c | 8 ++++---- hw/scsi/esp-pci.c | 14 +++++++++----- hw/scsi/lsi53c895a.c | 26 ++++++++++++++++---------- hw/scsi/megasas.c | 15 ++++++++++----- hw/scsi/vmw_pvscsi.c | 2 +- hw/usb/hcd-ehci-pci.c | 13 ++++++++----- hw/usb/hcd-ohci.c | 2 +- hw/usb/hcd-uhci.c | 2 +- hw/usb/hcd-xhci.c | 19 +++++++++++++------ hw/watchdog/wdt_i6300esb.c | 2 +- hw/xen/xen_platform.c | 28 ++++++++++++++++------------ 45 files changed, 258 insertions(+), 177 deletions(-)
Signature · 1 line
1.8.3.rc1.44.gb387c77.dirty