Skip to content

watchdog: ARM mpcore Improvements

Viresh Kumar linux-arm-kernel linux-watchdog 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest14 patches 0 repliesNew

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14watchdog/mpcore_wdt: Mark it as BROKENdrivers/watchdog/Kconfig+1 -13 replies
1/14watchdog/mpcore_wdt: Mark it as BROKEN+0 -01 reply
1/14watchdog/mpcore_wdt: Mark it as BROKEN+0 -00 replies
2/14watchdog/mpcore_wdt: convert to watchdog coredrivers/watchdog/Kconfig drivers/watchdog/mpcore_wdt.c+68 -2080 replies
3/14watchdog/mpcore_wdt: Fix multiline commentsdrivers/watchdog/mpcore_wdt.c+20 -220 replies
4/14watchdog/mpcore_wdt: Arrange #includes in alphabetical orderdrivers/watchdog/mpcore_wdt.c+6 -60 replies
5/14watchdog/mpcore_wdt: Set default heartbeat in probe instead of initdrivers/watchdog/mpcore_wdt.c+15 -140 replies
6/14watchdog/mpcore_wdt: convert to use module_platform_driver()drivers/watchdog/mpcore_wdt.c+1 -120 replies
7/14watchdog/mpcore_wdt: Add support for dev_pm_ops interfacedrivers/watchdog/mpcore_wdt.c+9 -90 replies
8/14watchdog/mpcore_wdt: disable wdt in suspend only if it is busydrivers/watchdog/mpcore_wdt.c+3 -10 replies
9/14watchdog/mpcore_wdt: replace (__raw_)readl/writel with lighter *_relaxed variantsdrivers/watchdog/mpcore_wdt.c+9 -90 replies
10/14watchdog/mpcore_wdt: Add support for WDIOC_GETBOOTSTATUS IOCTLarch/arm/include/asm/smp_twd.h drivers/watchdog/mpcore_wdt.c+6 -00 replies
11/14watchdog/mpcore_wdt: Add clock framework supportdrivers/watchdog/mpcore_wdt.c+39 -80 replies
12/14watchdog/mpcore_wdt: use correct clk_rate to program timeoutarch/arm/include/asm/smp_twd.h drivers/watchdog/mpcore_wdt.c+90 -190 replies
13/14watchdog/mpcore_wdt: Start registers from 0x00 instead of 0x20arch/arm/include/asm/smp_twd.h drivers/watchdog/mpcore_wdt.c+23 -200 replies
14/14watchdog/mpcore_wdt: Add DT probing support for ARM mpcore watchdogdrivers/watchdog/mpcore_wdt.c+12 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH V3 00/14] watchdog: ARM mpcore Improvements

** This still doesn't make it workable **

Hi,

ARM mpcore watchdog isn't workable and so is marked broken in the first patch of the series. Reasons are mentioned in 01/14 and important links are shared too.

Other are basically improvements which I have written more than a year back. I am just pushing them through as they still improve the driver (or broken driver). They still don't fix the issues pointed out by Marc Zyngier earlier. But as these are generic improvements I don't see why they can't be applied, even to a still broken driver.

I don't want somebody to waste time reinventing these patches, rather they can work on fixing the issues due to which this driver is broken.

I don't have hardware & time to fix the BROKEN part of this driver now :(

Link to the last version, nothing much changed after that. Just a resend:

http://lists.infradead.org/pipermail/linux-arm-kernel/2012-March/089076.html

Viresh Kumar (14):
watchdog/mpcore_wdt: Mark it as BROKEN watchdog/mpcore_wdt: convert to watchdog core watchdog/mpcore_wdt: Fix multiline comments watchdog/mpcore_wdt: Arrange #includes in alphabetical order watchdog/mpcore_wdt: Set default heartbeat in probe instead of init watchdog/mpcore_wdt: convert to use module_platform_driver() watchdog/mpcore_wdt: Add support for dev_pm_ops interface watchdog/mpcore_wdt: disable wdt in suspend only if it is busy watchdog/mpcore_wdt: replace (__raw_)readl/writel with lighter
*_relaxed variants
watchdog/mpcore_wdt: Add support for WDIOC_GETBOOTSTATUS IOCTL watchdog/mpcore_wdt: Add clock framework support watchdog/mpcore_wdt: use correct clk_rate to program timeout watchdog/mpcore_wdt: Start registers from 0x00 instead of 0x20 watchdog/mpcore_wdt: Add DT probing support for ARM mpcore watchdog

 arch/arm/include/asm/smp_twd.h |   7 -
 drivers/watchdog/Kconfig       |   3 +-
 drivers/watchdog/mpcore_wdt.c  | 529 ++++++++++++++++++++---------------------
 3 files changed, 256 insertions(+), 283 deletions(-)
Signature · 1 line
1.7.12.rc2.18.g61b472e