Skip to content

Fixes for the fetcher

Peter Kjellerstedt bitbake-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Allow checksums to be used for files retrieved using SFTPbitbake/lib/bb/fetch2/__init__.py+2 -20 replies
2/2Correct a typobitbake/lib/bb/fetch2/__init__.py+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Fixes for the fetcher

We need the SFTP fetcher for one of our recipes. As it turned out when I wrote the recipe, the fetcher failed to retrieve the sources because it wanted me to specify checksums for them. However, the checksums _were_ specified in the recipe.

After examining the code for the fetcher, it turned out that the list of fetchers that expect a checksum is hardcoded in the constructor of FetchData in lib/bb/fetch2/__init__.py, whereas verify_checksum() uses ud.method.supports_checksum() and ud.method.recommends_checksum() to determine if a checksum is needed. Needless to say, this of course failed as the hardcoded values did not match reality.

This patch updates the list of hardcoded fetchers to include SFTP, but I consider it more of a bandage, and someone with better Python skills than mine should rewrite the constructor to not use a hardcoded list.

//Peter

The following changes since commit efb8a460d2a977dbd481a0650fba8eb637c65bec:

package.bbclass: Fix sources contents (2013-05-14 08:52:47 +0300)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib pkj/fetch_sftp
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/fetch_sftp

Peter Kjellerstedt (2):
Allow checksums to be used for files retrieved using SFTP Correct a typo

 bitbake/lib/bb/fetch2/__init__.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
1.8.2.1