git-prompt: cleaning and improvement
Status from this message: Queued, and merged to 'pu' without the previous merge with the older
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 4 repliesApplied
- v14 patches 10 repliesSuperseded
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | t9903: add tests for git-prompt pcmodet/ | +254 | 0 replies | |
| 2/5 | git-prompt.sh: refactor colored prompt codecontrib/ | +26 | 0 replies | |
| 3/5 | t9903: remove redundant testst/ | +1 | 0 replies | |
| 4/5 | git-prompt.sh: do not print duplicate clean color codecontrib/ t/ | +5 | 0 replies | |
| 5/5 | git-prompt.sh: add missing information in commentscontrib/ | +15 | 0 replies |
Reviews trailers per patch
1 of 5 patches has a Reviewed-by or Acked-by.
| Patch | SZEDER Gábor |
|---|---|
| 1/5 | |
| 2/5 | |
| 3/5 | |
| 4/5 | A-b |
| 5/5 | With-suggestions-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/5] git-prompt: cleaning and improvement
Changes since the first version [1]:
- During refactorization in 2/5, mention what the lack of \[...\] can affect.
- New patch 3/5 that removes redundant tests (noticed by SZEDER Gábor [2])
- Rephrasing in 5/5:
- rephrasing suggested by SZEDER Gábor [3]
- rephrase some parts that mention only the "current branch name" being displayed in the prompt by stating that the "repository status" is displayed.
- explain the color codes in the ZSH precmd example (there was an explanation that applied only for the Bash example, but it was not clear that it did not apply to ZSH).
Following Gábor's example, I merged his patches series [4] to mine and published at:
https://github.com/erdavila/git.git bash-prompt-speedup-and-color-refactorization
Both Gábor's and my series were rebased/applied on top of the current master 9832cb9d4d.
Thanks,
Eduardo
[1] http://thread.gmane.org/gmane.comp.version-control.git/228566
[2] http://article.gmane.org/gmane.comp.version-control.git/228705
[3] http://article.gmane.org/gmane.comp.version-control.git/228707
[4] http://thread.gmane.org/gmane.comp.version-control.git/228851
Eduardo R. D'Avila (5):
t9903: add tests for git-prompt pcmode git-prompt.sh: refactor colored prompt code
t9903: remove redundant tests
git-prompt.sh: do not print duplicate clean color code git-prompt.sh: add missing information in comments
contrib/completion/git-prompt.sh | 111 ++++++++++++------------------ t/t9903-bash-prompt.sh | 141 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 182 insertions(+), 70 deletions(-)
Signature · 1 line
1.8.3.1.590.g42a98dd